Mac: Make calling WebContents::WasShown/WasHidden the responsibility of the content layer

content/browser/web_contents/web_contents_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Carbon/Carbon.h>
 
 #import "content/browser/web_contents/web_contents_view_mac.h"
 
 #include <string>
 
@@ skipping 49 matching lines @@
 - (void)registerDragTypes;
 - (void)setCurrentDragOperation:(NSDragOperation)operation;
 - (DropData*)dropData;
 - (void)startDragWithDropData:(const DropData&)dropData
             dragOperationMask:(NSDragOperation)operationMask
                         image:(NSImage*)image
                        offset:(NSPoint)offset;
 - (void)cancelDeferredClose;
 - (void)clearWebContentsView;
 - (void)closeTabAfterEvent;
+- (void)checkWebContentsShowState;
 - (void)viewDidBecomeFirstResponder:(NSNotification*)notification;
 - (content::WebContentsImpl*)webContents;
 @end
 
 namespace content {
 
 WebContentsView* CreateWebContentsView(
     WebContentsImpl* web_contents,
     WebContentsViewDelegate* delegate,
     RenderViewHostDelegateView** render_view_host_delegate_view) {
@@ skipping 524 matching lines @@
   NSSelectionDirection direction =
       static_cast<NSSelectionDirection>([[[notification userInfo]
           objectForKey:kSelectionDirection] unsignedIntegerValue]);
   if (direction == NSDirectSelection)
     return;
 
   [self webContents]->
       FocusThroughTabTraversal(direction == NSSelectingPrevious);
 }
 
+- (void)checkWebContentsShowState {

[Avi (use Gerrit), 2016/02/26 17:50:23]

We're not checking it, we're updating it, and I don't know what a "show state"
is.

We could totally reuse the name -updateWebContentsVisibility here, as it works.

[tapted, 2016/02/29 06:49:00]

Done.

+  WebContentsImpl* webContents = [self webContents];
+  if (!webContents || webContents->IsBeingDestroyed())
+    return;
+
+  const bool viewVisible = [self window] && ![self isHiddenOrHasHiddenAncestor];
+  webContents->UpdateWebContentsVisibility(viewVisible);
+}
+
 // When the subviews require a layout, their size should be reset to the size
 // of this view. (It is possible for the size to get out of sync as an
 // optimization in preparation for an upcoming WebContentsView resize.
 // http://crbug.com/264207)
 - (void)resizeSubviewsWithOldSize:(NSSize)oldBoundsSize {
   for (NSView* subview in self.subviews)
     [subview setFrame:self.bounds];
 }
 
 - (void)viewWillMoveToWindow:(NSWindow*)newWindow {
@@ skipping 28 matching lines @@
   WebContentsImpl* webContents = [self webContents];
   if (window && webContents && !webContents->IsBeingDestroyed()) {
     if ([window occlusionState] & NSWindowOcclusionStateVisible) {
       webContents->WasUnOccluded();
     } else {
       webContents->WasOccluded();
     }
   }
 }
 
+- (void)viewDidMoveToWindow {
+  [self checkWebContentsShowState];
+}
+
+- (void)viewDidHide {
+  [self checkWebContentsShowState];
+}
+
+- (void)viewDidUnhide {
+  [self checkWebContentsShowState];
+}
+
 @end