Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: tests/AAClipTest.cpp

Issue 1733113002: Unit Tests: eliminate stray SkDebugf()s. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dm/DM.cpp ('k') | tests/BitmapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/AAClipTest.cpp
diff --git a/tests/AAClipTest.cpp b/tests/AAClipTest.cpp
index faf45ed70be781dbc17d5d34a7db2b8718478ed9..1ea850688d590a29e67c1866ba873af671e95fe9 100644
--- a/tests/AAClipTest.cpp
+++ b/tests/AAClipTest.cpp
@@ -262,17 +262,18 @@ static void test_irect(skiatest::Reporter* reporter) {
bool nonEmptyAA = clip2.op(clip0, clip1, op);
bool nonEmptyBW = rgn2.op(rgn0, rgn1, op);
if (nonEmptyAA != nonEmptyBW || clip2.getBounds() != rgn2.getBounds()) {
- SkDebugf("[%d %d %d %d] %s [%d %d %d %d] = BW:[%d %d %d %d] AA:[%d %d %d %d]\n",
- r0.fLeft, r0.fTop, r0.right(), r0.bottom(),
- gRgnOpNames[j],
- r1.fLeft, r1.fTop, r1.right(), r1.bottom(),
- rgn2.getBounds().fLeft, rgn2.getBounds().fTop,
- rgn2.getBounds().right(), rgn2.getBounds().bottom(),
- clip2.getBounds().fLeft, clip2.getBounds().fTop,
- clip2.getBounds().right(), clip2.getBounds().bottom());
+ ERRORF(reporter, "%s %s "
+ "[%d %d %d %d] %s [%d %d %d %d] = BW:[%d %d %d %d] AA:[%d %d %d %d]\n",
+ nonEmptyAA == nonEmptyBW ? "true" : "false",
+ clip2.getBounds() == rgn2.getBounds() ? "true" : "false",
+ r0.fLeft, r0.fTop, r0.right(), r0.bottom(),
+ gRgnOpNames[j],
+ r1.fLeft, r1.fTop, r1.right(), r1.bottom(),
+ rgn2.getBounds().fLeft, rgn2.getBounds().fTop,
+ rgn2.getBounds().right(), rgn2.getBounds().bottom(),
+ clip2.getBounds().fLeft, clip2.getBounds().fTop,
+ clip2.getBounds().right(), clip2.getBounds().bottom());
}
- REPORTER_ASSERT(reporter, nonEmptyAA == nonEmptyBW);
- REPORTER_ASSERT(reporter, clip2.getBounds() == rgn2.getBounds());
SkMask maskBW, maskAA;
copyToMask(rgn2, &maskBW);
« no previous file with comments | « dm/DM.cpp ('k') | tests/BitmapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698