Issue 1733093002: [Test] have the provisional DocumentLoader protect itself

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1733093002: [Test] have the provisional DocumentLoader protect itself (Closed)

Created:
4 years, 10 months ago by Charlie Harrison

Modified:
4 years, 10 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[Test] have the provisional DocumentLoader protect itself This is a test CL to see if another approach at https://codereview.chromium.org/1714063002 could work without messing up CL history. BUG=

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+50 lines, -8 lines)			Patch
A	third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A +	third_party/WebKit/LayoutTests/http/tests/loading/stop-load-at-commit-expected.txt	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/DocumentLoader.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/DocumentLoader.cpp	View	3 chunks	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/loader/FrameLoader.cpp	View	4 chunks	+18 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Harrison

4 years, 10 months ago (2016-02-26 22:46:41 UTC) #1

Description was changed from

==========
[Test] have the provisional DocumentLoader protect itself
This is a test CL to see if another approach at
https://codereview.chromium.org/1714063002 could work without messing up
CL history.

BUG=
==========

to

==========
[Test] have the provisional DocumentLoader protect itself
This is a test CL to see if another approach at
https://codereview.chromium.org/1714063002 could work without messing up
CL history.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages