Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1733073002: Prepare inspector layout tests for ES2015 Function.name changes (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare inspector layout tests for ES2015 Function.name changes This patch changes the regexps that inspector layout tests use to filter inspector-internal function names out of stack trace dumps. Under ES2015, the evaluate* methods will no longer include the "InjectedScript." prefix in stack traces, since they'll be given instance "name" properties that precisely match the property name to which they're assigned in the InjectedScript source. BUG=588803 Committed: https://crrev.com/c7bf4cea0145d4be2b4141eb9b30f4b35a15ec6f Cr-Commit-Position: refs/heads/master@{#377818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
adamk
4 years, 10 months ago (2016-02-25 00:21:24 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2016-02-25 21:47:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733073002/1
4 years, 10 months ago (2016-02-25 22:44:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/187504)
4 years, 10 months ago (2016-02-26 03:47:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1733073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1733073002/1
4 years, 10 months ago (2016-02-26 04:35:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 05:34:58 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 05:36:10 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7bf4cea0145d4be2b4141eb9b30f4b35a15ec6f
Cr-Commit-Position: refs/heads/master@{#377818}

Powered by Google App Engine
This is Rietveld 408576698