Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tools/gn/visual_studio_writer.h

Issue 1733023002: GN: Fix CPU detection in Visual Studio generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | tools/gn/visual_studio_writer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.h
diff --git a/tools/gn/visual_studio_writer.h b/tools/gn/visual_studio_writer.h
index 8ca92fb01a5a8748c317f5a232acb9984f698f30..e9f2658e58b26ccbc18ffcb018b0fe4b6824e6a2 100644
--- a/tools/gn/visual_studio_writer.h
+++ b/tools/gn/visual_studio_writer.h
@@ -75,6 +75,8 @@ class VisualStudioWriter {
using SolutionFolders = std::vector<SolutionEntry*>;
explicit VisualStudioWriter(const BuildSettings* build_settings,
+ bool is_debug_config,
+ const char* config_platform,
Version version);
~VisualStudioWriter();
@@ -110,7 +112,7 @@ class VisualStudioWriter {
// Platform for solution configuration (Win32, x64). Some projects may be
// configured for different platform.
- std::string config_platform_;
+ const char* config_platform_;
// All projects contained by solution.
SolutionProjects projects_;
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | tools/gn/visual_studio_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698