Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: tools/gn/visual_studio_writer.h

Issue 1733023002: GN: Fix CPU detection in Visual Studio generator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | tools/gn/visual_studio_writer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 5 #ifndef TOOLS_GN_VISUAL_STUDIO_WRITER_H_
6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 6 #define TOOLS_GN_VISUAL_STUDIO_WRITER_H_
7 7
8 #include <iosfwd> 8 #include <iosfwd>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 // Absolute label dir path. 68 // Absolute label dir path.
69 std::string label_dir_path; 69 std::string label_dir_path;
70 // Configuration platform. May be different than solution config platform. 70 // Configuration platform. May be different than solution config platform.
71 std::string config_platform; 71 std::string config_platform;
72 }; 72 };
73 73
74 using SolutionProjects = std::vector<SolutionProject*>; 74 using SolutionProjects = std::vector<SolutionProject*>;
75 using SolutionFolders = std::vector<SolutionEntry*>; 75 using SolutionFolders = std::vector<SolutionEntry*>;
76 76
77 explicit VisualStudioWriter(const BuildSettings* build_settings, 77 explicit VisualStudioWriter(const BuildSettings* build_settings,
78 bool is_debug_config,
79 const char* config_platform,
78 Version version); 80 Version version);
79 ~VisualStudioWriter(); 81 ~VisualStudioWriter();
80 82
81 bool WriteProjectFiles(const Target* target, Err* err); 83 bool WriteProjectFiles(const Target* target, Err* err);
82 bool WriteProjectFileContents(std::ostream& out, 84 bool WriteProjectFileContents(std::ostream& out,
83 const SolutionProject& solution_project, 85 const SolutionProject& solution_project,
84 const Target* target, 86 const Target* target,
85 Err* err); 87 Err* err);
86 void WriteFiltersFileContents(std::ostream& out, const Target* target); 88 void WriteFiltersFileContents(std::ostream& out, const Target* target);
87 bool WriteSolutionFile(Err* err); 89 bool WriteSolutionFile(Err* err);
(...skipping 15 matching lines...) Expand all
103 const char* project_version_; 105 const char* project_version_;
104 106
105 // Visual Studio version string. 107 // Visual Studio version string.
106 const char* version_string_; 108 const char* version_string_;
107 109
108 // Indicates if project files are generated for Debug mode configuration. 110 // Indicates if project files are generated for Debug mode configuration.
109 bool is_debug_config_; 111 bool is_debug_config_;
110 112
111 // Platform for solution configuration (Win32, x64). Some projects may be 113 // Platform for solution configuration (Win32, x64). Some projects may be
112 // configured for different platform. 114 // configured for different platform.
113 std::string config_platform_; 115 const char* config_platform_;
114 116
115 // All projects contained by solution. 117 // All projects contained by solution.
116 SolutionProjects projects_; 118 SolutionProjects projects_;
117 119
118 // Absolute root solution folder path. 120 // Absolute root solution folder path.
119 std::string root_folder_path_; 121 std::string root_folder_path_;
120 122
121 // Folders for all solution projects. 123 // Folders for all solution projects.
122 SolutionFolders folders_; 124 SolutionFolders folders_;
123 125
124 // Semicolon-separated Windows SDK include directories. 126 // Semicolon-separated Windows SDK include directories.
125 std::string windows_kits_include_dirs_; 127 std::string windows_kits_include_dirs_;
126 128
127 // Path formatter for ninja targets. 129 // Path formatter for ninja targets.
128 PathOutput ninja_path_output_; 130 PathOutput ninja_path_output_;
129 131
130 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter); 132 DISALLOW_COPY_AND_ASSIGN(VisualStudioWriter);
131 }; 133 };
132 134
133 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_ 135 #endif // TOOLS_GN_VISUAL_STUDIO_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | tools/gn/visual_studio_writer.cc » ('j') | tools/gn/visual_studio_writer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698