Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1732913002: Revert of toBlob: If idle image encoding is postponed for too long, switch to main thread (Closed)

Created:
4 years, 10 months ago by xlai (Olivia)
Modified:
4 years, 10 months ago
Reviewers:
Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of toBlob: If idle image encoding is postponed for too long, switch to main thread (patchset #8 id:200001 of https://codereview.chromium.org/1665413004/ ) Reason for revert: I am suspecting that this CL is causing a leak in WebKit Leak bot. Reverting it first to inspect the source of problems. Original issue's description: > toBlob: If idle image encoding is postponed for too long, switch to main thread > > BUG=583070 > > Committed: https://crrev.com/dc5c70a312e24ca03d94696f16c5be318ce198d6 > Cr-Commit-Position: refs/heads/master@{#377054} TBR=junov@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583070 Committed: https://crrev.com/396fce9a5b6e14508ab56be6fd992f08f6991016 Cr-Commit-Position: refs/heads/master@{#377302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -379 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.h View 3 chunks +10 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 8 chunks +29 lines, -147 lines 0 comments Download
D third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreatorTest.cpp View 1 chunk +0 lines, -195 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
xlai (Olivia)
Created Revert of toBlob: If idle image encoding is postponed for too long, switch to ...
4 years, 10 months ago (2016-02-24 15:57:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732913002/1
4 years, 10 months ago (2016-02-24 15:58:34 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 10 months ago (2016-02-24 15:58:35 UTC) #4
Justin Novosad
On 2016/02/24 15:58:35, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
4 years, 10 months ago (2016-02-24 15:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732913002/1
4 years, 10 months ago (2016-02-24 16:16:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 16:19:52 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:21:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/396fce9a5b6e14508ab56be6fd992f08f6991016
Cr-Commit-Position: refs/heads/master@{#377302}

Powered by Google App Engine
This is Rietveld 408576698