Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1732903002: [fullcodegen] Fix assert for operand stack depth tracking. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Fix assert for operand stack depth tracking. This fixes a corner case that triggered an assert in full-codegens operand stack depth tracking. We stop pushing operands if we overflow the C-stack while iterating the AST. This makes the tracking go out of sync before we fully returned from the tree traversal, at which point the thrown RangeError will abort compilation. R=ishell@chromium.org TEST=mjsunit/regress/regress-crbug-589472 BUG=chromium:589472 LOG=n Committed: https://crrev.com/3baa290264f8f37a184fa8959fc18cd09af9a84c Cr-Commit-Position: refs/heads/master@{#34255}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Skip for interpreter. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -2 lines) Patch
M src/full-codegen/full-codegen.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-589472.js View 1 chunk +94 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-24 15:40:43 UTC) #1
Igor Sheludko
lgtm
4 years, 10 months ago (2016-02-24 15:48:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732903002/20001
4 years, 10 months ago (2016-02-24 15:49:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/15809)
4 years, 10 months ago (2016-02-24 15:54:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732903002/40001
4 years, 10 months ago (2016-02-24 16:20:20 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-24 16:29:25 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 16:29:58 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3baa290264f8f37a184fa8959fc18cd09af9a84c
Cr-Commit-Position: refs/heads/master@{#34255}

Powered by Google App Engine
This is Rietveld 408576698