Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 173283003: WebDocument::focusedNode should be focusedElement (Closed)

Created:
6 years, 10 months ago by maheshkk
Modified:
6 years, 10 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add WebDocument::focusedElement. WebDocument::focusedNode should be focusedElement. DOM, HTML, SVG specifications assume only elements can be focused. Blink exposes focusedNode api and returns WebNode casting from Element*. This change would make a cleaner API and expose focused WebElement which is more rich than WebNode. BUG=258763 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167657

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/web/WebDocument.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M public/web/WebDocument.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
maheshkk
Please take a look.
6 years, 10 months ago (2014-02-21 20:56:53 UTC) #1
tkent
lgtm I'll update the CL description for the followings. > WebDocument::focusedNode should be focusedElement Please ...
6 years, 10 months ago (2014-02-24 00:54:04 UTC) #2
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 10 months ago (2014-02-24 00:55:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/173283003/1
6 years, 10 months ago (2014-02-24 00:55:36 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-24 03:36:17 UTC) #5
Message was sent while issue was closed.
Change committed as 167657

Powered by Google App Engine
This is Rietveld 408576698