lib/src/backend/operating_system.dart - Issue 1732773003: Use identifiers in OperatingSystem.find.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/backend/operating_system.dart

Issue 1732773003: Use identifiers in OperatingSystem.find. (Closed) Base URL: git@github.com:dart-lang/test@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/backend/operating_system.dart

diff --git a/lib/src/backend/operating_system.dart b/lib/src/backend/operating_system.dart

index 45b14133f22f92d5390f70070a298ecba5c88aee..0e9c63784a1fa5abe231b41502a55edaca76c6ab 100644

--- a/lib/src/backend/operating_system.dart

+++ b/lib/src/backend/operating_system.dart

@@ -42,7 +42,8 @@ class OperatingSystem {

///

/// If no operating system is found, returns [none].

static OperatingSystem find(String name) =>

kevmoo 2016/02/24 23:54:59 Need to clarify name vs identifier in the arg, too

nweiz 2016/02/25 23:44:34 Done.

- all.firstWhere((platform) => platform.name == name, orElse: () => null);

+ all.firstWhere((platform) => platform.identifier == name,

+ orElse: () => null);

/// Finds an operating system by the return value from `dart:io`'s

/// `Platform.operatingSystem`.

« no previous file with comments | « no previous file | lib/src/runner/plugin/platform_helpers.dart » ('j') | no next file with comments »