Chromium Code Reviews

Issue 173273006: Unify (Pre)Parser::ParseObjectLiteral and add tests. (Closed)

Created:
6 years, 10 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Unify (Pre)Parser::ParseObjectLiteral and add tests. Notes: - The regexp in the ParseObjectLiteralComment was wrong, made it less wrong ( it's still wrong since trailing commas are not required / allowed). - Change in logic: In case we have "get somekeyword() { }", the "somekeyword" was not logged as a symbol by PreParser and not expected in the preparser data by Parser. This is unnecessary complication; in other contexts where keywords are allowed as identifiers, they are logged as symbols (see ParseIdentifierName). BUG=v8:3126 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19750

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+149 lines, -37 lines)
M src/parser.cc View 5 chunks +9 lines, -13 lines 0 comments
M src/preparser.cc View 3 chunks +22 lines, -22 lines 0 comments
M test/cctest/test-parsing.cc View 3 chunks +118 lines, -2 lines 0 comments

Messages

Total messages: 3 (0 generated)
marja
ulan, ptal
6 years, 10 months ago (2014-02-20 15:36:29 UTC) #1
ulan
lgtm
6 years, 10 months ago (2014-02-20 15:53:21 UTC) #2
marja
6 years, 9 months ago (2014-03-10 11:42:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19750 (presubmit successful).

Powered by Google App Engine