Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: skia/config/SkUserConfig.h

Issue 173257: Revert r24085 and r24086, restoring skia asserts to debug-only.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/tools/layout_tests/test_expectations.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 The Android Open Source Project 2 * Copyright (C) 2006 The Android Open Source Project
3 * 3 *
4 * Licensed under the Apache License, Version 2.0 (the "License"); 4 * Licensed under the Apache License, Version 2.0 (the "License");
5 * you may not use this file except in compliance with the License. 5 * you may not use this file except in compliance with the License.
6 * You may obtain a copy of the License at 6 * You may obtain a copy of the License at
7 * 7 *
8 * http://www.apache.org/licenses/LICENSE-2.0 8 * http://www.apache.org/licenses/LICENSE-2.0
9 * 9 *
10 * Unless required by applicable law or agreed to in writing, software 10 * Unless required by applicable law or agreed to in writing, software
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 69
70 /* Skia has lots of debug-only code. Often this is just null checks or other 70 /* Skia has lots of debug-only code. Often this is just null checks or other
71 parameter checking, but sometimes it can be quite intrusive (e.g. check that 71 parameter checking, but sometimes it can be quite intrusive (e.g. check that
72 each 32bit pixel is in premultiplied form). This code can be very useful 72 each 32bit pixel is in premultiplied form). This code can be very useful
73 during development, but will slow things down in a shipping product. 73 during development, but will slow things down in a shipping product.
74 74
75 By default, these mutually exclusive flags are defined in SkPreConfig.h, 75 By default, these mutually exclusive flags are defined in SkPreConfig.h,
76 based on the presence or absence of NDEBUG, but that decision can be changed 76 based on the presence or absence of NDEBUG, but that decision can be changed
77 here. 77 here.
78 */ 78 */
79 79 //#define SK_DEBUG
80 // Force SK_DEBUG even in release, so we get SkASSERTs. 80 //#define SK_RELEASE
81 // TODO(senorblanco): Remove this after a few reliability runs.
82 #define SK_DEBUG
83 #undef SK_RELEASE
84 81
85 82
86 /* If, in debugging mode, Skia needs to stop (presumably to invoke a debugger) 83 /* If, in debugging mode, Skia needs to stop (presumably to invoke a debugger)
87 it will call SK_CRASH(). If this is not defined it, it is defined in 84 it will call SK_CRASH(). If this is not defined it, it is defined in
88 SkPostConfig.h to write to an illegal address 85 SkPostConfig.h to write to an illegal address
89 */ 86 */
90 //#define SK_CRASH() *(int *)(uintptr_t)0 = 0 87 //#define SK_CRASH() *(int *)(uintptr_t)0 = 0
91 88
92 89
93 /* preconfig will have attempted to determine the endianness of the system, 90 /* preconfig will have attempted to determine the endianness of the system,
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 // assertion. 203 // assertion.
207 #define SK_CRASH() SkDebugf_FileLine(__FILE__, __LINE__, true, "SK_CRASH") 204 #define SK_CRASH() SkDebugf_FileLine(__FILE__, __LINE__, true, "SK_CRASH")
208 205
209 // For now (and to avoid rebaselining 1700+ tests), we'll use the old version 206 // For now (and to avoid rebaselining 1700+ tests), we'll use the old version
210 // of SkAlpha255To256. 207 // of SkAlpha255To256.
211 #define SK_USE_OLD_255_TO_256 208 #define SK_USE_OLD_255_TO_256
212 209
213 // ===== End Chrome-specific definitions ===== 210 // ===== End Chrome-specific definitions =====
214 211
215 #endif 212 #endif
OLDNEW
« no previous file with comments | « no previous file | webkit/tools/layout_tests/test_expectations.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698