Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1732563007: [NOT FOR COMMIT] Pass defaultObjectSize to get image size (Closed)

Created:
4 years, 10 months ago by davve
Modified:
4 years, 9 months ago
Reviewers:
cnmcswain82
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, piman+watch_chromium.org, je_julie, kinuko+watch, kouhei+svg_chromium.org, rwlbuis, Yoav Weiss, krit, drott+blinkwatch_chromium.org, aboxhall, aboxhall+watch_chromium.org, blink-reviews-css, blink-reviews-html_chromium.org, Justin Novosad, dglazkov+blink, Rik, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, vmpstr+blinkwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, philipj_slow, jbroman, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, dcheng, darktears, loading-reviews+fetch_chromium.org, Nate Chapin, pdr+graphicswatchlist_chromium.org, danakj+watch_chromium.org, tyoshino+watch_chromium.org, ajuma+watch-canvas_chromium.org, pdr+renderingwatchlist_chromium.org, nektar+watch_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, mlamouri+watch-blink_chromium.org, nektarios, f(malita), dtseng+watch_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NOT FOR COMMIT] Pass defaultObjectSize to get image size Pass defaultObjectSize down from CanvasImageSource::drawImage down to the Image implementations. BUG= CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -113 lines) Patch
M third_party/WebKit/Source/core/css/CSSCrossfadeValue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.h View 2 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ImageResource.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 3 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLImageElement.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/ImageDocument.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasImageSource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/ImageInputType.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ImageQualityController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/shapes/Shape.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleFetchedImageSet.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleGeneratedImage.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleImage.h View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StyleInvalidImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/StylePendingImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/filters/SVGFEImage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp View 6 chunks +11 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/imagebitmap/ImageBitmapRenderingContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/Cursor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/BitmapImage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.h View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/Image.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
cnmcswain82
4 years, 10 months ago (2016-02-24 14:31:46 UTC) #3
cnmcswain82
lgtm
4 years, 10 months ago (2016-02-24 14:31:49 UTC) #4
cnmcswain82
lgtm lgtm
4 years, 10 months ago (2016-02-24 14:31:53 UTC) #5
cnmcswain82
lgtm lgtm
4 years, 10 months ago (2016-02-24 14:31:54 UTC) #6
cnmcswain82
4 years, 10 months ago (2016-02-24 14:31:56 UTC) #7 
lgtm

lgtm

Powered by Google App Engine
This is Rietveld 408576698