Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1732543002: Add BUILD.gn for ios/third_party/fishhook. (Closed)

Created:
4 years, 10 months ago by baxley
Modified:
4 years, 10 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add BUILD.gn for ios/third_party/fishhook. Create GN build files for fishhook. BUG=589100 Committed: https://crrev.com/33bcc134504b89bd0609b99905693b1288ea202d Cr-Commit-Position: refs/heads/master@{#377372}

Patch Set 1 #

Total comments: 9

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A ios/third_party/fishhook/BUILD.gn View 1 1 chunk +19 lines, -0 lines 0 comments Download
M ios/third_party/fishhook/fishhook.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
baxley
4 years, 10 months ago (2016-02-24 00:49:38 UTC) #2
sdefresne
lgtm once the comments have been addressed https://codereview.chromium.org/1732543002/diff/1/ios/third_party/fishhook/BUILD.gn File ios/third_party/fishhook/BUILD.gn (right): https://codereview.chromium.org/1732543002/diff/1/ios/third_party/fishhook/BUILD.gn#newcode5 ios/third_party/fishhook/BUILD.gn:5: config("public_config") { ...
4 years, 10 months ago (2016-02-24 09:46:25 UTC) #3
baxley
Comments addressed. https://codereview.chromium.org/1732543002/diff/1/ios/third_party/fishhook/BUILD.gn File ios/third_party/fishhook/BUILD.gn (right): https://codereview.chromium.org/1732543002/diff/1/ios/third_party/fishhook/BUILD.gn#newcode5 ios/third_party/fishhook/BUILD.gn:5: config("public_config") { On 2016/02/24 09:46:25, sdefresne wrote: ...
4 years, 10 months ago (2016-02-24 15:29:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732543002/20001
4 years, 10 months ago (2016-02-24 15:30:32 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/149596)
4 years, 10 months ago (2016-02-24 15:45:52 UTC) #9
baxley
+ dpranke for BUILD.gn OWNERS.
4 years, 10 months ago (2016-02-24 15:49:39 UTC) #11
sdefresne
lgtm
4 years, 10 months ago (2016-02-24 15:57:56 UTC) #12
Dirk Pranke
lgtm
4 years, 10 months ago (2016-02-24 20:09:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732543002/20001
4 years, 10 months ago (2016-02-24 20:17:18 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 20:43:16 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 20:44:38 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/33bcc134504b89bd0609b99905693b1288ea202d
Cr-Commit-Position: refs/heads/master@{#377372}

Powered by Google App Engine
This is Rietveld 408576698