Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Unified Diff: net/url_request/url_request.h

Issue 1732493002: Prevent URLFetcher::AppendChunkedData from dereferencing NULL pointers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused variable Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_fetcher_impl_unittest.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.h
diff --git a/net/url_request/url_request.h b/net/url_request/url_request.h
index d3b0b7a7326b647d122ef7c8694bcc17a3595259..ccf53381e73713c996daf7c646fe74e0e5d035a8 100644
--- a/net/url_request/url_request.h
+++ b/net/url_request/url_request.h
@@ -46,7 +46,6 @@ class StackTrace;
namespace net {
-class ChunkedUploadDataStream;
class CookieOptions;
class HostPortPair;
class IOBuffer;
@@ -331,23 +330,6 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
// must not yet have a Delegate set.
void set_delegate(Delegate* delegate);
- // Indicates that the request body should be sent using chunked transfer
- // encoding. This method may only be called before Start() is called.
- void EnableChunkedUpload();
-
- // Appends the given bytes to the request's upload data to be sent
- // immediately via chunked transfer encoding. When all data has been added,
- // set |is_last_chunk| to true to indicate the end of upload data. All chunks
- // but the last must have |bytes_len| > 0.
- //
- // This method may be called only after calling EnableChunkedUpload().
- //
- // Despite the name of this method, over-the-wire chunk boundaries will most
- // likely not match the "chunks" appended with this function.
- void AppendChunkToUpload(const char* bytes,
- int bytes_len,
- bool is_last_chunk);
-
// Sets the upload data.
void set_upload(scoped_ptr<UploadDataStream> upload);
@@ -783,9 +765,6 @@ class NET_EXPORT URLRequest : NON_EXPORTED_BASE(public base::NonThreadSafe),
scoped_ptr<URLRequestJob> job_;
scoped_ptr<UploadDataStream> upload_data_stream_;
- // TODO(mmenke): Make whether or not an upload is chunked transparent to the
- // URLRequest.
- ChunkedUploadDataStream* upload_chunked_data_stream_;
std::vector<GURL> url_chain_;
GURL first_party_for_cookies_;
« no previous file with comments | « net/url_request/url_fetcher_impl_unittest.cc ('k') | net/url_request/url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698