Modernize ElementAnnotationImpl.isX getters.

Modernize ElementAnnotationImpl.isX getters.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/65b03d653cee181951b9d402d1ca0dcc452d36eb

[pquitslund, 2016-02-25 16:53:59]

LGTM!

[Brian Wilkerson, 2016-02-25 17:02:12]

LGTM

https://codereview.chromium.org/1732383002/diff/1/pkg/analyzer/lib/src/dart/e...
File pkg/analyzer/lib/src/dart/element/element.dart (right):

https://codereview.chromium.org/1732383002/diff/1/pkg/analyzer/lib/src/dart/e...
pkg/analyzer/lib/src/dart/element/element.dart:1625: if
(element?.library?.isDartCore == true) {
I'm obviously not used to the null-aware operators yet; it took me a while to
figure out that this is equivalent.

It looks really weird to have a "== true" test in a condition, but I think I
like it better than the other option I can think of:

  element?.library?.isDartCore ?? false

[scheglov, 2016-02-25 17:08:11]

Description was changed from

==========
Modernize ElementAnnotationImpl.isX getters.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=
==========

to

==========
Modernize ElementAnnotationImpl.isX getters.

R=brianwilkerson@google.com, pquitslund@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/65b03d653cee181951b9d402d1ca0dcc452d36eb
==========

[scheglov, 2016-02-25 17:08:13]

Committed patchset #1 (id:1) manually as
65b03d653cee181951b9d402d1ca0dcc452d36eb (presubmit successful).