Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1732373003: Revert of Mojo bindings environment: remove usage in gles2. (Closed)

Created:
4 years, 10 months ago by yzshen1
Modified:
4 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo bindings environment: remove usage in gles2. (patchset #1 id:1 of https://codereview.chromium.org/1725123002/ ) Reason for revert: This causes crashes: https://bugs.chromium.org/p/chromium/issues/detail?id=589964 The shell and the application belong to different modules, so they have different MessageLoop::current() / MessagePumpMojo::current() / etc. Although these values are in thread-local storage, we refer to them using global variables which are different in different modules. Original issue's description: > Mojo bindings environment: remove usage in gles2. > > BUG=585942 > > Committed: https://crrev.com/67adb0d1a11573b9d0bd4fbe144f5e979327009d > Cr-Commit-Position: refs/heads/master@{#377314} TBR=sky@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585942 Committed: https://crrev.com/3f372c3212400b0a26cb6a3d6d28fa1d6584e3f2 Cr-Commit-Position: refs/heads/master@{#377822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -17 lines) Patch
M components/bitmap_uploader/bitmap_uploader.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/context_provider.cc View 2 chunks +3 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M mojo/gles2/gles2_context.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/gles2/gles2_context.cc View 1 chunk +5 lines, -1 line 0 comments Download
M mojo/gles2/gles2_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/public/c/gles2/gles2.h View 2 chunks +6 lines, -4 lines 0 comments Download
M mojo/public/platform/native/gles2_thunks.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/platform/native/gles2_thunks.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Created Revert of Mojo bindings environment: remove usage in gles2.
4 years, 10 months ago (2016-02-26 05:11:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732373003/1
4 years, 10 months ago (2016-02-26 05:12:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732373003/1
4 years, 10 months ago (2016-02-26 05:33:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 05:46:30 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 05:47:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f372c3212400b0a26cb6a3d6d28fa1d6584e3f2
Cr-Commit-Position: refs/heads/master@{#377822}

Powered by Google App Engine
This is Rietveld 408576698