Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1732363002: Delay deferring resource requests until after first checking cache and extensions (Closed)

Created:
4 years, 10 months ago by jkarlin
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds an experimental change to the ResourceScheduler to defer just before going to network instead of before starting. This way the cache and extensions can be checked before deferring. This is expected to add cache contention but can potentially reduce PLT because requests get a head start and reduce SpeedIndex because cached images can be displayed earlier. Depends on a non-existant Finch trial to run, the trial is to be added later. Design doc: https://docs.google.com/document/d/1TSI3jwozVB_nueWJxzi8uKbgDfsGZRZqw8tvtD-P1Iw/edit?usp=sharing BUG=328741

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Early returns ftw #

Patch Set 4 : remove extra paren #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M content/browser/loader/resource_scheduler.cc View 1 2 3 3 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (2 generated)
jkarlin
Description was changed from ========== Delay resource scheduling decisions until network access. Moved the ResourceScheduler ...
4 years, 10 months ago (2016-02-25 15:41:33 UTC) #1
jkarlin
4 years, 10 months ago (2016-02-25 15:59:04 UTC) #2
Description was changed from

==========
Delay resource scheduling decisions until network access.

Moved the ResourceScheduler to operate on requests before they use the
network instead of as soon as they are created.  This gets it out of the
way of the cache and service workers (including the new tab page).

This is a rebase of https://codereview.chromium.org/1706903003/

BUG=587507
==========

to

==========
Adds an experimental change to the ResourceScheduler to defer just
before going to network instead of before starting.  This way the
cache and extensions can be checked before deferring.  This is
expected to add cache contention but can potentially reduce PLT
because requests get a head start and reduce SpeedIndex because cached
images can be displayed earlier.

Depends on a non-existant Finch trial to run, the trial is to be added later.

Design doc:
https://docs.google.com/document/d/1TSI3jwozVB_nueWJxzi8uKbgDfsGZRZqw8tvtD-P1...

BUG=328741
==========

Powered by Google App Engine
This is Rietveld 408576698