Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1732333002: MIPS64: Fix '[stubs] Introduce a dedicated FastNewObjectStub.' (Closed)

Created:
4 years, 10 months ago by Alan Li
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix '[stubs] Introduce a dedicated FastNewObjectStub.' Port ba2077aac3a775523ca3fc9600fcf76f55e8d1c2 Original commit message: Move the already existing fast case for %NewObject into a dedicated FastNewObjectStub that we can utilize in places where we would otherwise fallback to %NewObject immediately, which is rather expensive. Also use FastNewObjectStub as the generic implementation of JSCreate, which should make constructor inlining based on SharedFunctionInfo (w/o specializing to a concrete closure) viable soon. BUG= Committed: https://crrev.com/9945b3dddc4d1375f10b0ab22e9b1760c44b391f Cr-Commit-Position: refs/heads/master@{#34330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -138 lines) Patch
M src/mips64/builtins-mips64.cc View 3 chunks +14 lines, -138 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
balazs.kilvady
Description should be: MIPS64: Fix '[stubs] Introduce a dedicated FastNewObjectStub.' Port ba2077aac3a775523ca3fc9600fcf76f55e8d1c2 Original commit message: ...
4 years, 10 months ago (2016-02-25 19:06:08 UTC) #3
Alan Li
On 2016/02/25 19:06:08, balazs.kilvady wrote: > Description should be: > MIPS64: Fix '[stubs] Introduce a ...
4 years, 10 months ago (2016-02-25 19:12:12 UTC) #5
balazs.kilvady
lgtm
4 years, 10 months ago (2016-02-25 19:27:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732333002/1
4 years, 10 months ago (2016-02-26 15:35:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 15:55:34 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 15:56:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9945b3dddc4d1375f10b0ab22e9b1760c44b391f
Cr-Commit-Position: refs/heads/master@{#34330}

Powered by Google App Engine
This is Rietveld 408576698