Toward a green tools/build.py -cprecompiler -rdart_precompiled:

Make tools/build.py -cprecompiler -rdart_precompiled green:

- Create a separate compilation output directory for each VMOptions varient so they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a wrapper script so crashes in the snapshotter are correctly identified by the test harness.
- Delete the assembly source for the precompiled shared library as we go to limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/3fd5ffdbd4d90749f3f4bb9bb3ad34eafcd99f7c

[rmacnak, 2016-02-25 22:02:26]

Description was changed from

==========
Toward a green tools/build.py -cprecompiler -rdart_precompiled:

- Create a separate compilation output directory for each VMOptions varient.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Mark all library prefixes as loaded when snapshotting so they don't later
attempt to look at their tree-shaken list of imports.
==========

to

==========
Toward a green tools/build.py -cprecompiler -rdart_precompiled:

- Create a separate compilation output directory for each VMOptions varient.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Mark all library prefixes as loaded when snapshotting so they don't later
attempt to look at their tree-shaken list of imports.
==========

[rmacnak, 2016-02-25 22:52:23]

rmacnak@google.com changed reviewers:
+ asiva@google.com, fschneider@google.com

[rmacnak, 2016-03-01 19:04:06]

Description was changed from

==========
Toward a green tools/build.py -cprecompiler -rdart_precompiled:

- Create a separate compilation output directory for each VMOptions varient.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Mark all library prefixes as loaded when snapshotting so they don't later
attempt to look at their tree-shaken list of imports.
==========

to

==========
Toward a green tools/build.py -cprecompiler -rdart_precompiled:

- Create a separate compilation output directory for each VMOptions varient.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Delete the assembly source for the precompiled shared library as we go to
limit space required to run the test suite (now 20G for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Mark all library prefixes as loaded when snapshotting so they don't later
attempt to look at their tree-shaken list of imports.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
==========

[rmacnak, 2016-03-01 22:04:57]

Description was changed from

==========
Toward a green tools/build.py -cprecompiler -rdart_precompiled:

- Create a separate compilation output directory for each VMOptions varient.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Delete the assembly source for the precompiled shared library as we go to
limit space required to run the test suite (now 20G for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Mark all library prefixes as loaded when snapshotting so they don't later
attempt to look at their tree-shaken list of imports.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
==========

to

==========
Make tools/build.py -cprecompiler -rdart_precompiled green:

- Create a separate compilation output directory for each VMOptions varient so
they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Delete the assembly source for the precompiled shared library as we go to
limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by
tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.
==========

[rmacnak, 2016-03-01 22:16:10]

PTAL

[Florian Schneider, 2016-03-01 22:53:45]

lgtm

https://codereview.chromium.org/1732323005/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1732323005/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:10365: if (Dart::IsRunningPrecompiledCode()) {
Should this be just 

#if defined(DART_PRECOMPILED_RUNTIME)

?

[rmacnak, 2016-03-01 23:03:30]

https://codereview.chromium.org/1732323005/diff/40001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1732323005/diff/40001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:10365: if (Dart::IsRunningPrecompiledCode()) {
On 2016/03/01 22:53:44, Florian Schneider wrote:
> Should this be just 
> 
> #if defined(DART_PRECOMPILED_RUNTIME)
> 
> ?

Issue #25894

[rmacnak, 2016-03-01 23:19:15]

Description was changed from

==========
Make tools/build.py -cprecompiler -rdart_precompiled green:

- Create a separate compilation output directory for each VMOptions varient so
they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Delete the assembly source for the precompiled shared library as we go to
limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by
tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.
==========

to

==========
Make tools/build.py -cprecompiler -rdart_precompiled green:

- Create a separate compilation output directory for each VMOptions varient so
they can run in parallel.
- Run both the snapshotter and assembler from the test harness instead of a
wrapper script so crashes in the snapshotter are correctly identified by the
test harness.
- Delete the assembly source for the precompiled shared library as we go to
limit space required to run the test suite (now 61GB for X64 release).
- Remove the VMOption --optimization-counter-threshold in when running
precompilation tests.
- Don't look at a library prefix's import list during load(), it was removed by
tree-shaking.
- Trace types of TypeParameters.
- Trace types of a Function's owner and parent.
- Update status file for remaining 4 failures under http://dartbug.com/25892.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3fd5ffdbd4d90749f3f4bb9bb3ad34eafcd99f7c
==========

[rmacnak, 2016-03-01 23:19:17]

Committed patchset #3 (id:40001) manually as
3fd5ffdbd4d90749f3f4bb9bb3ad34eafcd99f7c (presubmit successful).