Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 1732323002: Remove layer for readback (Closed)

Created:
4 years, 10 months ago by Jinsuk Kim
Modified:
4 years, 9 months ago
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su, aelias_OOO_until_Jul13, danakj
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove layer for readback A dedicated layer for readback is not necessary any more thanks to the latest fixes crrev.com/1398633003, etc. Removed related logic. BUG=574537 Committed: https://crrev.com/b5e173cdb92e95a18b35deca996b4463033996a3 Cr-Commit-Position: refs/heads/master@{#379230}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixed a bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -41 lines) Patch
M content/browser/renderer_host/compositor_impl_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 3 chunks +6 lines, -28 lines 0 comments Download
M ui/android/window_android_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
no sievers
https://codereview.chromium.org/1732323002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/1732323002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode911 content/browser/renderer_host/render_widget_host_view_android.cc:911: compositor->RequestCopyOfOutputOnRootLayer(std::move(request)); You want to use |layer_| here or you'll ...
4 years, 10 months ago (2016-02-25 23:26:11 UTC) #2
Jinsuk Kim
https://codereview.chromium.org/1732323002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc File content/browser/renderer_host/render_widget_host_view_android.cc (right): https://codereview.chromium.org/1732323002/diff/1/content/browser/renderer_host/render_widget_host_view_android.cc#newcode911 content/browser/renderer_host/render_widget_host_view_android.cc:911: compositor->RequestCopyOfOutputOnRootLayer(std::move(request)); On 2016/02/25 23:26:11, sievers wrote: > You want ...
4 years, 10 months ago (2016-02-26 00:53:30 UTC) #4
no sievers
lgtm
4 years, 10 months ago (2016-02-26 18:32:28 UTC) #5
Jinsuk Kim
dtrainor@chromium.org: Please review changes in ui/android
4 years, 9 months ago (2016-03-02 03:56:15 UTC) #7
David Trainor- moved to gerrit
lgtm
4 years, 9 months ago (2016-03-04 05:13:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732323002/20001
4 years, 9 months ago (2016-03-04 05:14:31 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-04 06:32:38 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-04 06:33:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5e173cdb92e95a18b35deca996b4463033996a3
Cr-Commit-Position: refs/heads/master@{#379230}

Powered by Google App Engine
This is Rietveld 408576698