Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1732313003: Revert of Plugin Power Saver: Remove Size Recheck hack in plugin placeholders. (Closed)

Created:
4 years, 10 months ago by Will Harris
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@0047-pps-skip-poster-for-same-origin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Plugin Power Saver: Remove Size Recheck hack in plugin placeholders. (patchset #5 id:100001 of https://codereview.chromium.org/1491893004/ ) Reason for revert: this is causing RELEASE_ASSERT crashes, see bug 545039 Original issue's description: > Plugin Power Saver: Remove Size Recheck hack in plugin placeholders. > > See https://code.google.com/p/chromium/issues/detail?id=343769. > > The Blink faulty geometry is _almost_ fixed, and it seems fixed-enough > to remove the (awful) size recheck hack for plugin placeholders. > > As a nice side effect, removing this size recheck hack will also make > essential plugins with posters no longer have an ugly delay. > > BUG=497429, 560590 > > Committed: https://crrev.com/f74fd9e11c465ff68c954cc30a1856300a9c54be > Cr-Commit-Position: refs/heads/master@{#372674} TBR=groby@chromium.org,tommycli@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=497429, 560590, 545039 Committed: https://crrev.com/c916fccc772dce7924d8cf1266ba4e71344c37c3 Cr-Commit-Position: refs/heads/master@{#377710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -122 lines) Patch
M components/plugins/renderer/loadable_plugin_placeholder.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/plugins/renderer/loadable_plugin_placeholder.cc View 5 chunks +161 lines, -122 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Will Harris
Created Revert of Plugin Power Saver: Remove Size Recheck hack in plugin placeholders.
4 years, 10 months ago (2016-02-25 21:45:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732313003/1
4 years, 10 months ago (2016-02-25 21:51:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732313003/1
4 years, 10 months ago (2016-02-25 22:03:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732313003/1
4 years, 10 months ago (2016-02-25 22:33:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732313003/1
4 years, 10 months ago (2016-02-25 23:04:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732313003/1
4 years, 10 months ago (2016-02-25 23:33:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 23:44:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 23:45:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c916fccc772dce7924d8cf1266ba4e71344c37c3
Cr-Commit-Position: refs/heads/master@{#377710}

Powered by Google App Engine
This is Rietveld 408576698