Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 1732273002: [Interpreter] Implement TypeOf bytecode using the TypeofStub. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Implement TypeOf bytecode using the TypeofStub. We already have a code stub that implements Typeof, so we don't need a special runtime entry here to implement the TypeOf handler. R=rmcilroy@chromium.org Committed: https://crrev.com/c81bbda7e4114995b2288da61308a1639d6b81c8 Cr-Commit-Position: refs/heads/master@{#34283}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M src/interpreter/interpreter.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-interpreter.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-25 10:54:54 UTC) #1
Benedikt Meurer
Hey Ross, Simple refactoring to use the existing stub instead of the custom runtime call. ...
4 years, 10 months ago (2016-02-25 10:55:31 UTC) #2
rmcilroy
LGTM, thanks.
4 years, 10 months ago (2016-02-25 10:57:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732273002/1
4 years, 10 months ago (2016-02-25 10:57:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/14288)
4 years, 10 months ago (2016-02-25 11:17:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732273002/1
4 years, 10 months ago (2016-02-25 11:29:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 11:40:53 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 11:41:50 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c81bbda7e4114995b2288da61308a1639d6b81c8
Cr-Commit-Position: refs/heads/master@{#34283}

Powered by Google App Engine
This is Rietveld 408576698