Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks

Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1732263003

BUG=skia:4691
Committed: https://skia.googlesource.com/skia/+/3552ba18ee41e135d6fc52228adae37794fc15ff

[robertphillips, 2016-02-25 14:02:38]

Description was changed from

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
==========

to

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-02-25 14:03:56]

Description was changed from

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[robertphillips, 2016-02-25 14:03:57]

robertphillips@google.com changed reviewers:
+ caryclark@google.com

[robertphillips, 2016-02-25 14:35:18]

PTAL

[caryclark, 2016-02-25 14:48:23]

caryclark@google.com changed reviewers:
+ bungeman@google.com

[caryclark, 2016-02-25 14:48:55]

lgtm (added bungeman to review as well)

[bungeman-skia, 2016-02-25 15:41:18]

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkFontDescript...
File src/core/SkFontDescriptor.cpp (right):

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkFontDescript...
src/core/SkFontDescriptor.cpp:104: return false;
For consistency with the above 'default' handling, a SkDEBUGFAIL("Could not read
font data.") should go before the return, so that at least in debug we die early
with a more specific message. Note that this probably means removing the
SkDEBUGFAIL in SkTypeface.cpp and SkWhitelistTypeface.cpp below, since they'll
never actually happen (and their message is more generic in any event). In
general, this seems to point out the general lack of error reporting or recovery
in this whole mechanism.

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkPaint.cpp#ne...
src/core/SkPaint.cpp:2127: 
nit: here and in the other files where an SkFontDescriptor is declared, there is
this blank line between the declaration and the 'if' which initializes it. This
seems quite artificial and somewhat misleading, as the declaration should be
visually more strongly attached to the use than the unrelated block above it.

[robertphillips, 2016-02-25 15:53:22]

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkFontDescript...
File src/core/SkFontDescriptor.cpp (right):

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkFontDescript...
src/core/SkFontDescriptor.cpp:104: return false;
On 2016/02/25 15:41:17, bungeman1 wrote:
> For consistency with the above 'default' handling, a SkDEBUGFAIL("Could not
read
> font data.") should go before the return, so that at least in debug we die
early
> with a more specific message. Note that this probably means removing the
> SkDEBUGFAIL in SkTypeface.cpp and SkWhitelistTypeface.cpp below, since they'll
> never actually happen (and their message is more generic in any event). In
> general, this seems to point out the general lack of error reporting or
recovery
> in this whole mechanism.

Done.

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkPaint.cpp
File src/core/SkPaint.cpp (right):

https://codereview.chromium.org/1732263003/diff/40001/src/core/SkPaint.cpp#ne...
src/core/SkPaint.cpp:2127: 
On 2016/02/25 15:41:17, bungeman1 wrote:
> nit: here and in the other files where an SkFontDescriptor is declared, there
is
> this blank line between the declaration and the 'if' which initializes it.
This
> seems quite artificial and somewhat misleading, as the declaration should be
> visually more strongly attached to the use than the unrelated block above it.

Done.

[robertphillips, 2016-02-25 16:41:37]

Description was changed from

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

BUG=skia:4691
==========

[bungeman-skia, 2016-02-25 17:33:41]

lgtm

[robertphillips, 2016-02-25 17:44:11]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 17:44:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732263003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732263003/60001

[commit-bot: I haz the power, 2016-02-25 17:53:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 17:53:21]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-02-25 18:57:10]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-02-25 18:57:11]

The patchset sent to the CQ was uploaded after l-g-t-m from caryclark@google.com
Link to the patchset: https://codereview.chromium.org/1732263003/#ps60001
(title: "Address code review issues")

[commit-bot: I haz the power, 2016-02-25 18:57:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732263003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732263003/60001

[commit-bot: I haz the power, 2016-02-25 18:58:51]

Description was changed from

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

BUG=skia:4691
==========

to

==========
Make skpinfo able to inspect SK_PICT_TYPEFACE_TAG blocks
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

BUG=skia:4691

Committed:
https://skia.googlesource.com/skia/+/3552ba18ee41e135d6fc52228adae37794fc15ff
==========

[commit-bot: I haz the power, 2016-02-25 18:58:52]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3552ba18ee41e135d6fc52228adae37794fc15ff