[debugger] add utility to print break location.

[debugger] add utility to print break location.

This is to help debugging missing break locations.

R=vogelheim@chromium.org

Committed: https://crrev.com/6695290c5e7efbfbea24bc70ff7e2f8558f000c8
Cr-Commit-Position: refs/heads/master@{#34284}

[Yang, 2016-02-25 10:13:47]

On 2016/02/25 09:49:20, Yang wrote:

In case you are wondering:

$ out/ia32/Debug/cctest DebugStepLocals --print-break-location
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                    ^
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                              ^
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                                      ^
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                                                  ^
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                                                                  ^
[debug] break in function 'foo'.
[debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
Math.floor(b);}foo()
[debug]                                                                         
          ^

[Yang, 2016-02-25 10:14:10]

On 2016/02/25 10:13:47, Yang wrote:
> On 2016/02/25 09:49:20, Yang wrote:
> 
> In case you are wondering:
> 
> $ out/ia32/Debug/cctest DebugStepLocals --print-break-location
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                    ^
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                              ^
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                                      ^
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                                                  ^
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                                                                  ^
> [debug] break in function 'foo'.
> [debug] function foo() {   var a,b;  a = 1;  b = a + 2;  b = 1 + 2 + 3;  a =
> Math.floor(b);}foo()
> [debug]                                                                       
 
>           ^

... and of course rietveld adds linebreaks.

[vogelheim, 2016-02-25 10:42:48]

lgtm

https://codereview.chromium.org/1732253002/diff/20001/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/1732253002/diff/20001/src/debug/debug.cc#newc...
src/debug/debug.cc:2353: return;
super nitpick: Maybe remove? return in this branch but not the other is a bit
inconsistent, since they're both at the end of the function execution.

[Yang, 2016-02-25 11:36:48]

Patchset #3 (id:40001) has been deleted

[Yang, 2016-02-25 11:37:44]

On 2016/02/25 10:42:48, vogelheim wrote:
> lgtm
> 
> https://codereview.chromium.org/1732253002/diff/20001/src/debug/debug.cc
> File src/debug/debug.cc (right):
> 
>
https://codereview.chromium.org/1732253002/diff/20001/src/debug/debug.cc#newc...
> src/debug/debug.cc:2353: return;
> super nitpick: Maybe remove? return in this branch but not the other is a bit
> inconsistent, since they're both at the end of the function execution.

you are right. I forgot to remove that return after I refactored the code a bit.

[Yang, 2016-02-25 11:37:47]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-02-25 11:37:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
vogelheim@chromium.org
Link to the patchset: https://codereview.chromium.org/1732253002/#ps60001
(title: "address comment")

[commit-bot: I haz the power, 2016-02-25 11:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1732253002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1732253002/60001

[commit-bot: I haz the power, 2016-02-25 11:59:16]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-02-25 12:00:13]

Description was changed from

==========
[debugger] add utility to print break location.

This is to help debugging missing break locations.

R=vogelheim@chromium.org
==========

to

==========
[debugger] add utility to print break location.

This is to help debugging missing break locations.

R=vogelheim@chromium.org

Committed: https://crrev.com/6695290c5e7efbfbea24bc70ff7e2f8558f000c8
Cr-Commit-Position: refs/heads/master@{#34284}
==========

[commit-bot: I haz the power, 2016-02-25 12:00:14]

Patchset 3 (id:??) landed as
https://crrev.com/6695290c5e7efbfbea24bc70ff7e2f8558f000c8
Cr-Commit-Position: refs/heads/master@{#34284}