Use std::lower_bound() in a couple places.

Use std::lower_bound() in a couple places.

Do some cleanups along the way.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/f8e21f34e9b67c5b9e754e949c58a5113ea4d746

[Lei Zhang, 2016-02-25 20:11:26]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2016-02-25 20:11:27]

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:209: {78, 10001}, {81, 10002}, {79, 10003},
{84, 10004}, {83, 10005},
Uhh, these weren't sorted by |codepage| value.

[Tom Sepez, 2016-02-25 20:32:53]

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:202: uint8_t charset;
Can we call this CODEPAGE_MAP and flip the order of the members?  A
CodepageToCharsetTable should contain { codepage, charset} pairs.

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:209: {78, 10001}, {81, 10002}, {79, 10003},
{84, 10004}, {83, 10005},
On 2016/02/25 20:11:27, Lei Zhang wrote:
> Uhh, these weren't sorted by |codepage| value.
But they were sorted by the wrong index value due to the above confusion.

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:288:
std::lower_bound(g_Codepage2CharsetTable, pEnd, codepage,
std::binary_search() for an exact hit and avoid the retest at line 292?

https://codereview.chromium.org/1732223002/diff/1/xfa/src/fgas/src/localizati...
File xfa/src/fgas/src/localization/fx_locale.cpp (right):

https://codereview.chromium.org/1732223002/diff/1/xfa/src/fgas/src/localizati...
xfa/src/fgas/src/localization/fx_locale.cpp:2775:
std::lower_bound(g_FXLocaleTimeZoneData, pEnd, dwHash,
ditto for binary_search.

[Lei Zhang, 2016-02-25 20:48:16]

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:202: uint8_t charset;
On 2016/02/25 20:32:53, Tom Sepez wrote:
> Can we call this CODEPAGE_MAP and flip the order of the members?  A
> CodepageToCharsetTable should contain { codepage, charset} pairs.

Done.

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:209: {78, 10001}, {81, 10002}, {79, 10003},
{84, 10004}, {83, 10005},
On 2016/02/25 20:32:53, Tom Sepez wrote:
> On 2016/02/25 20:11:27, Lei Zhang wrote:
> > Uhh, these weren't sorted by |codepage| value.
> But they were sorted by the wrong index value due to the above confusion.

No they weren't sorted by |charset| either.

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:288:
std::lower_bound(g_Codepage2CharsetTable, pEnd, codepage,
On 2016/02/25 20:32:53, Tom Sepez wrote:
> std::binary_search() for an exact hit and avoid the retest at line 292?

std::binary_search() returns a bool, not an iterator/pointer.

[Tom Sepez, 2016-02-25 22:20:14]

lgtm

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
File core/src/fxge/ge/fx_ge_fontmap.cpp (right):

https://codereview.chromium.org/1732223002/diff/1/core/src/fxge/ge/fx_ge_font...
core/src/fxge/ge/fx_ge_fontmap.cpp:288:
std::lower_bound(g_Codepage2CharsetTable, pEnd, codepage,
On 2016/02/25 20:48:16, Lei Zhang wrote:
> On 2016/02/25 20:32:53, Tom Sepez wrote:
> > std::binary_search() for an exact hit and avoid the retest at line 292?
> 
> std::binary_search() returns a bool, not an iterator/pointer.
Ah, Carry on.

[Lei Zhang, 2016-02-25 22:35:28]

Description was changed from

==========
Use std::lower_bound() in a couple places.

Do some cleanups along the way.
==========

to

==========
Use std::lower_bound() in a couple places.

Do some cleanups along the way.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/f8e21f34e9b67c5b9e754e949c58a5113ea4...
==========

[Lei Zhang, 2016-02-25 22:35:29]

Committed patchset #3 (id:40001) manually as
f8e21f34e9b67c5b9e754e949c58a5113ea4d746 (presubmit successful).