[MD settings] using paper and google colors in settings

chrome/browser/resources/settings/settings_shared_css.html

 /* Copyright 2016 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
 /**
  * @fileoverview
  * Common styles for Material Design settings.
  */
 
 <dom-module id="settings-shared">
   <template>
     <style>
       :root {
         --settings-secondary: {
-          color: #969696;
+          color: var(--paper-grey-500);
           font-weight: 400;
         }
       }
 
       h2 {
         @apply(--layout-center);
         color: var(--paper-grey-500);
         display: flex;
         font-size: 100%;
         font-weight: 500;
         margin: 0;
         min-height: 40px;
       }
 
       iron-icon {
-        color: #969696;
+        color: var(--paper-grey-300);
       }
 
       iron-icon[icon=done] {
-        color: rgb(0, 128, 0);
+        color: var(--google-green-500);
       }
 
       paper-button {
         margin: 0;
         min-width: auto;
       }
 
       paper-button[toggles][active] {
-        background-color: LightGray;
+        background-color: var(--paper-grey-300);
       }
 
       span ~ a {
         -webkit-margin-start: 4px;
       }
 
       [is='action-link'],
       [is='action-link']:active,
       [is='action-link']:hover,
       [is='action-link']:visited,
       paper-button.primary-button {

[Dan Beam, 2016/02/25 00:08:17]

could you just add to this rule, actually

paper-button.primary-button,
paper-button.tertiary-button {

[dschuyler, 2016/02/25 00:19:07]

Hmm, the tertiary-button has the color inside
a --paper-button:.  I think that may behave
differently (i.e. are ya sure?).

[Dan Beam, 2016/02/25 00:44:47]

it is different: it's slower ;)

https://codereview.chromium.org/1725183002/diff/20001/chrome/browser/resource...

[dschuyler, 2016/02/25 21:32:25]

Done.

         /* TODO(dbeam): change all other colors in this file into --google or
          * --paper where applicable. */

[dschuyler, 2016/02/25 00:19:07]

I'll do a followup to remove this comment as well.

[Dan Beam, 2016/02/25 00:44:47]

Acknowledged.

         color: var(--google-blue-700);
       }
 
       [is='action-link']:hover {
         /* TODO(dbeam): check with bettes@ on this one, but I'm pretty sure we
          * shouldn't be showing much :hover stuff on Polymer pages. */
         text-decoration: none;
       }
 
       paper-button.primary-button {
         --paper-button: {
           font-weight: 500;
           text-align: start;
         };
         margin: 0 -0.57em;  /* Offsets default paper-button padding. */
       }
 
       paper-button.secondary-button {
         --paper-button: {
-          color: #5a5a5a;
+          color: var(--paper-grey-700);
           text-decoration: none;
           font-weight: 500;
         };
       }
 
       paper-button.tertiary-button {
         --paper-button: {
-          color: rgb(51, 103, 214);
+          color: var(--google-blue-700);

[Dan Beam, 2016/02/25 00:08:17]

^ and remove this

[dschuyler, 2016/02/25 00:19:07]

Acknowledged.

           font-weight: 400;
           text-decoration: none;
         };
       }
 
       paper-radio-button {
         --paper-radio-button-checked-color: var(--google-blue-500);
         --paper-radio-button-label-spacing: 18px;
-        --paper-radio-button-unchecked-color: #969696;
+        --paper-radio-button-unchecked-color: var(--paper-grey-500);
         -webkit-margin-start: 2px;
       }
 
       .text-elide {
         overflow: hidden;
         text-overflow: ellipsis;
         white-space: nowrap;
       }
 
       .button-row {
@@ skipping 25 matching lines @@
       .list-item {
         @apply(--layout-center);
         display: flex;
         min-height: 40px;
         padding: 0;
       }
 
       /* This button has no ink ripple */
       .list-item.list-button {
         @apply(--layout-center);
-        color: rgb(66, 133, 244);
+        color: var(--google-blue-500);
         font-weight: 500;
         text-decoration: none;
       }
 
       .list-item iron-icon {
         @apply(--layout-center);
         height: 20px;
         width: 20px;
       }
 
@@ skipping 10 matching lines @@
         white-space: nowrap;
       }
 
       .list-item > paper-icon-item {
         padding: 0;
       }
 
       /* This button has no ink ripple. */
       .list-item.list-button {
         @apply(--layout-center);
-        color: rgb(66, 133, 244);
+        color: var(--google-blue-500);
         font-weight: 500;
       }

[Dan Beam, 2016/02/25 00:08:17]

is this a copy... did I do this from a merge conflict maybe?

[dschuyler, 2016/02/25 00:19:07]

Done.

 
       .settings-card {
         padding: 8px 0;
       }
 
       .settings-box {
         @apply(--layout-center);
         border-top: 1px solid var(--paper-grey-300);
         display: flex;
         min-height: 40px;
@@ skipping 56 matching lines @@
       .vertical-list > div:first-of-type {
         border-top: none;
       }
 
       .vertical-list > div {
         border-top: 1px solid var(--paper-grey-300);
       }
     </style>
   </template>
 </dom-module>