Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 173212: Bring the Mac Chromium render theme up to date and easier to keep merged. Chr... (Closed)

Created:
11 years, 4 months ago by Avi (use Gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews_googlegroups.com, darin (slow to review)
Visibility:
Public.

Description

Bring the Mac Chromium render theme up to date and easier to keep merged. Chromium side of things. BUG=http://crbug.com/19604 TEST=no visible change on Leopard, draws correctly on Snow Leopard Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26471

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 6

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M DEPS View 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M webkit/webkit.gyp View 1 2 3 4 5 4 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Avi (use Gerrit)
Chromium side of things. We need to enable NEW_THEMES only on the Mac. (Don't want ...
11 years, 4 months ago (2009-08-21 19:15:37 UTC) #1
Amanda Walker
lgtm, pending upstream side of this change
11 years, 4 months ago (2009-08-21 19:59:40 UTC) #2
Avi (use Gerrit)
Updated to avoid touching the config file (which is being hacked at)
11 years, 3 months ago (2009-09-10 21:25:59 UTC) #3
Avi (use Gerrit)
A quick review of the gyp file before deps? Significant changes after the last review, ...
11 years, 3 months ago (2009-09-17 16:37:15 UTC) #4
Mark Mentovai
LG http://codereview.chromium.org/173212/diff/7001/8001 File webkit/webkit.gyp (right): http://codereview.chromium.org/173212/diff/7001/8001#newcode131 Line 131: 'WTF_USE_NEW_THEME=1', I don't think we ever get ...
11 years, 3 months ago (2009-09-17 17:12:59 UTC) #5
Avi (use Gerrit)
http://codereview.chromium.org/173212/diff/7001/8001 File webkit/webkit.gyp (right): http://codereview.chromium.org/173212/diff/7001/8001#newcode131 Line 131: 'WTF_USE_NEW_THEME=1', On 2009/09/17 17:12:59, Mark Mentovai wrote: > ...
11 years, 3 months ago (2009-09-17 17:27:25 UTC) #6
Mark Mentovai
11 years, 3 months ago (2009-09-17 17:32:43 UTC) #7
lg

http://codereview.chromium.org/173212/diff/7001/8001
File webkit/webkit.gyp (right):

http://codereview.chromium.org/173212/diff/7001/8001#newcode131
Line 131: 'WTF_USE_NEW_THEME=1',
Avi wrote:
> Aren't they done with the config.in file? I used to have this in there, but
> there was a previous CL that went in and changed things around, putting a lot
> more in this file, in preparation for getting rid of our config.in altogether.

config.h.in is gone, you can talk to yaar for more details.

The macros we used to put into config.h.in are transitionally defined here in
the .gyp file, so that's correct.  I was just surprised to see a WTF_ macro
being defined directly instead of an ENABLE_ or something else.

(Would this count as a feature define?)

Powered by Google App Engine
This is Rietveld 408576698