Bring the Mac Chromium render theme up to date and easier to keep merged. Chr...

Bring the Mac Chromium render theme up to date and easier to keep merged. Chromium side of things.

BUG=http://crbug.com/19604
TEST=no visible change on Leopard, draws correctly on Snow Leopard


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26471

[Avi (use Gerrit), 2009-08-21 19:15:37]

Chromium side of things. We need to enable NEW_THEMES only on the Mac. (Don't
want to touch RenderThemeChromiumWindows.)

[Amanda Walker, 2009-08-21 19:59:40]

lgtm, pending upstream side of this change

[Avi (use Gerrit), 2009-09-10 21:25:59]

Updated to avoid touching the config file (which is being hacked at)

[Avi (use Gerrit), 2009-09-17 16:37:15]

A quick review of the gyp file before deps? Significant changes after the last
review, and I know you're in the office.

[Mark Mentovai, 2009-09-17 17:12:59]

LG

http://codereview.chromium.org/173212/diff/7001/8001
File webkit/webkit.gyp (right):

http://codereview.chromium.org/173212/diff/7001/8001#newcode131
Line 131: 'WTF_USE_NEW_THEME=1',
I don't think we ever get other WTF defines by just defining WTF_ names
ourselves.  This is OK right now, but could you see if we need to align this
with how other WTF defines work?

http://codereview.chromium.org/173212/diff/7001/8001#newcode660
Line 660: # Not using USE_NEW_THEME except on Mac (will include there).
You can do a little better than "will include there."  Add a subject to your
predicate.

http://codereview.chromium.org/173212/diff/7001/8001#newcode827
Line 827: ['include',
'/third_party/WebKit/WebCore/platform/graphics/mac/FloatPointMac\\.mm$'],
nice.

[Avi (use Gerrit), 2009-09-17 17:27:25]

http://codereview.chromium.org/173212/diff/7001/8001
File webkit/webkit.gyp (right):

http://codereview.chromium.org/173212/diff/7001/8001#newcode131
Line 131: 'WTF_USE_NEW_THEME=1',
On 2009/09/17 17:12:59, Mark Mentovai wrote:
> This is OK right now, but could you see if we need to align this
> with how other WTF defines work?

Aren't they done with the config.in file? I used to have this in there, but
there was a previous CL that went in and changed things around, putting a lot
more in this file, in preparation for getting rid of our config.in altogether.

http://codereview.chromium.org/173212/diff/7001/8001#newcode660
Line 660: # Not using USE_NEW_THEME except on Mac (will include there).
On 2009/09/17 17:12:59, Mark Mentovai wrote:
> You can do a little better than "will include there."  Add a subject to your
> predicate.

Rephrased.

[Mark Mentovai, 2009-09-17 17:32:43]

lg

http://codereview.chromium.org/173212/diff/7001/8001
File webkit/webkit.gyp (right):

http://codereview.chromium.org/173212/diff/7001/8001#newcode131
Line 131: 'WTF_USE_NEW_THEME=1',
Avi wrote:
> Aren't they done with the config.in file? I used to have this in there, but
> there was a previous CL that went in and changed things around, putting a lot
> more in this file, in preparation for getting rid of our config.in altogether.

config.h.in is gone, you can talk to yaar for more details.

The macros we used to put into config.h.in are transitionally defined here in
the .gyp file, so that's correct.  I was just surprised to see a WTF_ macro
being defined directly instead of an ENABLE_ or something else.

(Would this count as a feature define?)