Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 17321002: Fix wrong header guards found by clang's new Wheader-guard. (Closed)

Created:
7 years, 6 months ago by Nico
Modified:
7 years, 6 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, gavinp+memory_chromium.org, garykac+watch_chromium.org, feature-media-reviews_chromium.org, scheib+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, sergeyu+watch_chromium.org, lambroslambrou+watch_chromium.org
Visibility:
Public.

Description

Fix wrong header guards found by clang's new Wheader-guard. Example diagnostic: In file included from ../../ppapi/tests/test_flash_file.cc:5: ../../ppapi/tests/test_flash_file.h:5:9: error: 'PAPPI_TESTS_TEST_FLASH_FILE_H_' is used as a header guard here, followed by #define of a different macro [-Werror,-Wheader-guard] ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../ppapi/tests/test_flash_file.h:6:9: note: 'PPAPI_TESTS_TEST_FLASH_FILE_H_' is defined here; did you mean 'PAPPI_TESTS_TEST_FLASH_FILE_H_'? ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ PAPPI_TESTS_TEST_FLASH_FILE_H_ 1 error generated. BUG=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206837

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M base/memory/memory_pressure_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_device_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_input_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/fake_audio_output_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/dump_files.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_file.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_mouse_lock.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Hi Ben, can I get a toplevel lg for this? Then I don't have to ...
7 years, 6 months ago (2013-06-17 21:46:26 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 6 months ago (2013-06-17 22:14:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/17321002/2001
7 years, 6 months ago (2013-06-17 22:17:13 UTC) #3
Nico
7 years, 6 months ago (2013-06-17 23:48:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r206837 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698