Rename variables in update_reference_builds.py, and add comments.

Rename variables in update_reference_builds.py, and add comments.

After trying to run update_reference_builds, I found that when trying to get an official Chrome build, what I had to give was a Chrome version number (like 34.0.1797.1).

Although "version", "revision" and "build number" all have similar meanings and different meanings in different contexts, my understanding is that:
  Chrome version number = 4 numbers separated by dots, as described at http://www.chromium.org/developers/version-numbers.
  Chromium SVN revision number: A number like 251904.
  Build number: May refer to the third number in the Chrome version number (e.g. 1797).

The purpose of this CL is to change variable names so that they reflect these definitions.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254694

[qyearsley, 2014-02-20 02:44:36]

Hi shadi and tonyg, could you took a look at this CL, which changes a bunch of
variable names in update_reference_build.py and adds some method docstrings? Are
the names and comments correct?

Also, I wasn't able to successfully update the reference builds, and I was
wondering if I could get some help with that. After running, I got output like
this:

...
INFO:root:Extracting ...
INFO:root:Extracting ...
INFO:root:Extracting ...
INFO:root:['svn', 'stat', '--no-ignore'] reference_builds/reference_builds
CRITICAL:root:svn: warning: '.' is not a working copy

INFO:root:
INFO:root:Successfully updated reference builds. Move to
reference_builds/reference_builds and make a change with gcl.

After moving to reference_builds/reference_builds and running gcl change, I got:

To use gcl, you need to be in a subversion checkout.

Any idea what I might do so that my subversion checkout is right?

[tonyg, 2014-02-20 02:49:43]

lgtm

Lovely :)

[shadi1, 2014-02-20 03:46:01]

LGTM thanks for the fixes, this is more readable :)

As for the errors, try running first:
svn ls svn://svn.chromium.org/chrome/trunk/deps/reference_builds


I just ran this and it worked:
~/chromium/src/tools/update_reference_build.py -p Linux_x64 -b 34.0.1847.4

[qyearsley, 2014-02-20 05:11:27]

On 2014/02/20 03:46:01, shadi1 wrote:
> LGTM thanks for the fixes, this is more readable :)
> 
> As for the errors, try running first:
> svn ls svn://svn.chromium.org/chrome/trunk/deps/reference_builds
> 
> 
> I just ran this and it worked:
> ~/chromium/src/tools/update_reference_build.py -p Linux_x64 -b 34.0.1847.4

Thanks for that -- it worked after I authenticated myself for SVN. Added a note
about this at the top of the file.

[qyearsley, 2014-02-20 05:11:30]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-02-20 12:46:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/173203003/60001

[commit-bot: I haz the power, 2014-02-20 14:39:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 14:39:48]

Try jobs failed on following builders: linux_chromium_rel

[tonyg, 2014-02-20 14:57:32]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-02-20 14:58:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/173203003/60001

[commit-bot: I haz the power, 2014-02-20 14:59:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-20 14:59:33]

Try jobs failed on following builders: linux_chromium_rel

[qyearsley, 2014-03-04 02:00:17]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2014-03-04 02:00:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qyearsley@chromium.org/173203003/60001

[commit-bot: I haz the power, 2014-03-04 06:58:01]

Change committed as 254694