Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1732023002: Fix webkit_unit_tests on Android failing from missing MediaCodecUtil (Closed)

Created:
4 years, 10 months ago by agrieve
Modified:
4 years, 10 months ago
Reviewers:
bokan, pkotwicz
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 Committed: https://crrev.com/2639811c0b8d88362a0c0d4970718d8bfef83742 Cr-Commit-Position: refs/heads/master@{#377323}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Source/web/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (8 generated)
agrieve
There were 373 commits in the blame list, so decided to fix the error rather ...
4 years, 10 months ago (2016-02-24 16:51:14 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732023002/1
4 years, 10 months ago (2016-02-24 16:53:41 UTC) #4
bokan
Does this need a corresponding fix in a GYP? I'm don't really know the build ...
4 years, 10 months ago (2016-02-24 16:53:50 UTC) #5
agrieve
On 2016/02/24 16:53:50, bokan wrote: > Does this need a corresponding fix in a GYP? ...
4 years, 10 months ago (2016-02-24 17:02:08 UTC) #8
pkotwicz
LGTM
4 years, 10 months ago (2016-02-24 17:16:30 UTC) #9
bokan
rs lgtm
4 years, 10 months ago (2016-02-24 17:18:38 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 18:10:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732023002/1
4 years, 10 months ago (2016-02-24 18:17:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-24 18:29:42 UTC) #16
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 18:30:35 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2639811c0b8d88362a0c0d4970718d8bfef83742
Cr-Commit-Position: refs/heads/master@{#377323}

Powered by Google App Engine
This is Rietveld 408576698