|
|
DescriptionFix webkit_unit_tests on Android failing from missing MediaCodecUtil
BUG=589493
Committed: https://crrev.com/2639811c0b8d88362a0c0d4970718d8bfef83742
Cr-Commit-Position: refs/heads/master@{#377323}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 18 (8 generated)
agrieve@chromium.org changed reviewers: + bokan@chromium.org
There were 373 commits in the blame list, so decided to fix the error rather than look for which to revert.
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732023002/1
Does this need a corresponding fix in a GYP? I'm don't really know the build system well so I'm not a good reviewer, but if you can get someone else to vouch for this I'll rubber stamp it.
Description was changed from ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 ========== to ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 ==========
agrieve@chromium.org changed reviewers: + pkotwicz@chromium.org
On 2016/02/24 16:53:50, bokan wrote: > Does this need a corresponding fix in a GYP? > > I'm don't really know the build system well so I'm not a good reviewer, but if > you can get someone else to vouch for this I'll rubber stamp it. Yeah, had no idea who knew about media / content / blink things :S This type of failure generally happens just in GN, since GYP's all_dependent_settings is more pervasive and skirts this (while causing other issues). +pkotwicz for sanity check.
LGTM
rs lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1732023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1732023002/1
Message was sent while issue was closed.
Description was changed from ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 ========== to ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 ========== to ========== Fix webkit_unit_tests on Android failing from missing MediaCodecUtil BUG=589493 Committed: https://crrev.com/2639811c0b8d88362a0c0d4970718d8bfef83742 Cr-Commit-Position: refs/heads/master@{#377323} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2639811c0b8d88362a0c0d4970718d8bfef83742 Cr-Commit-Position: refs/heads/master@{#377323} |