Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: trunk/src/chrome/browser/resources/inline_login/inline_login.js

Issue 173193005: Revert 251503 "Implement inline signin with iframe" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/resources/inline_login/inline_login.js
===================================================================
--- trunk/src/chrome/browser/resources/inline_login/inline_login.js (revision 252157)
+++ trunk/src/chrome/browser/resources/inline_login/inline_login.js (working copy)
@@ -49,7 +49,10 @@
*/
function loadAuthExtension(data) {
authExtHost.load(data.authMode, data, onAuthCompleted);
- $('contents').classList.toggle('loading', true);
+ // Do not show loading spinner to give user a faster response
+ // with inline flows.
+ $('contents').classList.toggle('loading',
+ data.authMode != cr.login.GaiaAuthHost.AuthMode.INLINE);
}
/**

Powered by Google App Engine
This is Rietveld 408576698