Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1731903003: Added cursor navigation support for standard text fields and changed selection notifications so tha… (Closed)

Created:
4 years, 10 months ago by nektarios
Modified:
4 years, 10 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, Elly Fong-Jones, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added cursor navigation support for standard text fields and changed selection notifications so that they work on previous versions of Mac. I still need to figure out why delete doesn’t work. BUG=530826 TESTED=Manually with VoiceOver R=dmazzoni@chromium.org Committed: https://crrev.com/c8870aac3cd92263e38b703b8eeba916910be5b2 Cr-Commit-Position: refs/heads/master@{#377557}

Patch Set 1 #

Patch Set 2 : Fixed GetTextForRange to handle text fields. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -29 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 chunks +11 lines, -9 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 8 chunks +24 lines, -13 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 1 chunk +10 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
nektarios
4 years, 10 months ago (2016-02-24 21:01:56 UTC) #1
nektarios
4 years, 10 months ago (2016-02-24 21:08:35 UTC) #3
dmazzoni
lgtm
4 years, 10 months ago (2016-02-24 22:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731903003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731903003/20001
4 years, 10 months ago (2016-02-25 08:24:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 11:30:05 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 11:32:42 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8870aac3cd92263e38b703b8eeba916910be5b2
Cr-Commit-Position: refs/heads/master@{#377557}

Powered by Google App Engine
This is Rietveld 408576698