Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 1731893004: Fix perf breakage after crrev.com/1660383002 (Closed)

Created:
4 years, 10 months ago by Primiano Tucci (use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
haraken, hajimehoshi, bashi
CC:
chromium-reviews, blink-reviews, kinuko+watch, tkent
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix perf breakage after crrev.com/1660383002 crrev.com/1660383002 introduced a typo which caused the createDiscardableMemoryAllocatorDump method to reach the NOTREACHED base method. This caused various breakages on the perf bots. BUG=548254 NOPRESUBMIT=true TBR=haraken@chromium.org,hajimehoshi@chromium.org Committed: https://crrev.com/94a1988874793255dca1567a7dacb2f4936444ec Cr-Commit-Position: refs/heads/master@{#377829}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/WebKit/Source/platform/web_process_memory_dump_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/web_process_memory_dump_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
Primiano Tucci (use gerrit)
PTAL
4 years, 10 months ago (2016-02-26 04:19:03 UTC) #2
bashi
non-owner lgtm. I think we can add TBR=haraken@
4 years, 10 months ago (2016-02-26 04:20:17 UTC) #3
Primiano Tucci (use gerrit)
TBR-ing haraken as perf bots are currently broken
4 years, 10 months ago (2016-02-26 04:21:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731893004/20001
4 years, 10 months ago (2016-02-26 04:22:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 06:13:55 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/94a1988874793255dca1567a7dacb2f4936444ec Cr-Commit-Position: refs/heads/master@{#377829}
4 years, 10 months ago (2016-02-26 06:15:08 UTC) #12
haraken
4 years, 10 months ago (2016-02-26 08:35:54 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698