Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: test/unittests/interpreter/source-position-table-unittest.cc

Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Really fix leak. SourcePositionTableBuilder is member of a zone-allocated object. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/interpreter/source-position-table-unittest.cc
diff --git a/test/unittests/interpreter/source-position-table-unittest.cc b/test/unittests/interpreter/source-position-table-unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..22825cb229e1ad1d43290dca52abf3d894bf8a13
--- /dev/null
+++ b/test/unittests/interpreter/source-position-table-unittest.cc
@@ -0,0 +1,72 @@
+// Copyright 2016 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "src/v8.h"
+
+#include "src/interpreter/source-position-table.h"
+#include "test/unittests/test-utils.h"
+
+namespace v8 {
+namespace internal {
+namespace interpreter {
+
+class SourcePositionTableTest : public TestWithIsolateAndZone {
+ public:
+ SourcePositionTableTest() {}
+ ~SourcePositionTableTest() override {}
+};
+
+// Some random offsets, mostly at 'suspicious' bit boundaries.
+static int offsets[] = {0, 1, 2, 3, 4, 30, 31, 32,
+ 33, 62, 63, 64, 65, 126, 127, 128,
+ 129, 250, 1000, 9999, 12000, 31415926};
+
+TEST_F(SourcePositionTableTest, EncodeStatement) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ for (int i = 0; i < arraysize(offsets); i++) {
+ builder.AddStatementPosition(offsets[i], offsets[i]);
+ }
+
+ // To test correctness, we rely on the assertions in ToSourcePositionTable().
+ // (Also below.)
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, EncodeExpression) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+ for (int i = 0; i < arraysize(offsets); i++) {
+ builder.AddExpressionPosition(offsets[i], offsets[i]);
+ }
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+TEST_F(SourcePositionTableTest, EncodeAscending) {
+ SourcePositionTableBuilder builder(isolate(), zone());
+
+ int accumulator = 0;
+ for (int i = 0; i < arraysize(offsets); i++) {
+ accumulator += offsets[i];
+ if (i % 2) {
+ builder.AddStatementPosition(accumulator, accumulator);
+ } else {
+ builder.AddExpressionPosition(accumulator, accumulator);
+ }
+ }
+
+ // Also test negative offsets:
+ for (int i = 0; i < arraysize(offsets); i++) {
+ accumulator -= offsets[i];
+ if (i % 2) {
+ builder.AddStatementPosition(accumulator, accumulator);
+ } else {
+ builder.AddExpressionPosition(accumulator, accumulator);
+ }
+ }
+
+ CHECK(!builder.ToSourcePositionTable().is_null());
+}
+
+} // namespace interpreter
+} // namespace internal
+} // namespace v8
« no previous file with comments | « src/objects-inl.h ('k') | test/unittests/unittests.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698