Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/objects-inl.h

Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Really fix leak. SourcePositionTableBuilder is member of a zone-allocated object. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/unittests/interpreter/source-position-table-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 3880 matching lines...) Expand 10 before | Expand all | Expand 10 after
3891 3891
3892 int BytecodeArray::parameter_count() const { 3892 int BytecodeArray::parameter_count() const {
3893 // Parameter count is stored as the size on stack of the parameters to allow 3893 // Parameter count is stored as the size on stack of the parameters to allow
3894 // it to be used directly by generated code. 3894 // it to be used directly by generated code.
3895 return READ_INT_FIELD(this, kParameterSizeOffset) >> kPointerSizeLog2; 3895 return READ_INT_FIELD(this, kParameterSizeOffset) >> kPointerSizeLog2;
3896 } 3896 }
3897 3897
3898 3898
3899 ACCESSORS(BytecodeArray, constant_pool, FixedArray, kConstantPoolOffset) 3899 ACCESSORS(BytecodeArray, constant_pool, FixedArray, kConstantPoolOffset)
3900 ACCESSORS(BytecodeArray, handler_table, FixedArray, kHandlerTableOffset) 3900 ACCESSORS(BytecodeArray, handler_table, FixedArray, kHandlerTableOffset)
3901 ACCESSORS(BytecodeArray, source_position_table, FixedArray, 3901 ACCESSORS(BytecodeArray, source_position_table, ByteArray,
3902 kSourcePositionTableOffset) 3902 kSourcePositionTableOffset)
3903 3903
3904
3905 Address BytecodeArray::GetFirstBytecodeAddress() { 3904 Address BytecodeArray::GetFirstBytecodeAddress() {
3906 return reinterpret_cast<Address>(this) - kHeapObjectTag + kHeaderSize; 3905 return reinterpret_cast<Address>(this) - kHeapObjectTag + kHeaderSize;
3907 } 3906 }
3908 3907
3909 3908
3910 int BytecodeArray::BytecodeArraySize() { return SizeFor(this->length()); } 3909 int BytecodeArray::BytecodeArraySize() { return SizeFor(this->length()); }
3911 3910
3912 3911
3913 ACCESSORS(FixedTypedArrayBase, base_pointer, Object, kBasePointerOffset) 3912 ACCESSORS(FixedTypedArrayBase, base_pointer, Object, kBasePointerOffset)
3914 3913
(...skipping 3768 matching lines...) Expand 10 before | Expand all | Expand 10 after
7683 #undef WRITE_INT64_FIELD 7682 #undef WRITE_INT64_FIELD
7684 #undef READ_BYTE_FIELD 7683 #undef READ_BYTE_FIELD
7685 #undef WRITE_BYTE_FIELD 7684 #undef WRITE_BYTE_FIELD
7686 #undef NOBARRIER_READ_BYTE_FIELD 7685 #undef NOBARRIER_READ_BYTE_FIELD
7687 #undef NOBARRIER_WRITE_BYTE_FIELD 7686 #undef NOBARRIER_WRITE_BYTE_FIELD
7688 7687
7689 } // namespace internal 7688 } // namespace internal
7690 } // namespace v8 7689 } // namespace v8
7691 7690
7692 #endif // V8_OBJECTS_INL_H_ 7691 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/unittests/interpreter/source-position-table-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698