Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: src/interpreter/source-position-table.h

Issue 1731883003: Encode interpreter::SourcePositionTable as variable-length ints. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Really fix leak. SourcePositionTableBuilder is member of a zone-allocated object. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_INTERPRETER_SOURCE_POSITION_TABLE_H_ 5 #ifndef V8_INTERPRETER_SOURCE_POSITION_TABLE_H_
6 #define V8_INTERPRETER_SOURCE_POSITION_TABLE_H_ 6 #define V8_INTERPRETER_SOURCE_POSITION_TABLE_H_
7 7
8 #include "src/assert-scope.h" 8 #include "src/assert-scope.h"
9 #include "src/checks.h"
9 #include "src/handles.h" 10 #include "src/handles.h"
10 #include "src/zone.h"
11 #include "src/zone-containers.h" 11 #include "src/zone-containers.h"
12 12
13 namespace v8 { 13 namespace v8 {
14 namespace internal { 14 namespace internal {
15 15
16 class BytecodeArray; 16 class BytecodeArray;
17 class FixedArray; 17 class ByteArray;
18 class Isolate; 18 class Isolate;
19 class Zone;
19 20
20 namespace interpreter { 21 namespace interpreter {
21 22
23 struct PositionTableEntry {
24 PositionTableEntry()
25 : bytecode_offset(0), source_position(0), is_statement(false) {}
26 PositionTableEntry(int bytecode, int source, bool statement)
27 : bytecode_offset(bytecode),
28 source_position(source),
29 is_statement(statement) {}
30
31 int bytecode_offset;
32 int source_position;
33 bool is_statement;
34 };
35
22 class SourcePositionTableBuilder { 36 class SourcePositionTableBuilder {
23 public: 37 public:
24 explicit SourcePositionTableBuilder(Isolate* isolate, Zone* zone) 38 explicit SourcePositionTableBuilder(Isolate* isolate, Zone* zone)
25 : isolate_(isolate), entries_(zone) {} 39 : isolate_(isolate),
40 bytes_(zone),
41 #ifdef ENABLE_SLOW_DCHECKS
42 raw_entries_(zone),
43 #endif
44 previous_() {
45 }
26 46
27 void AddStatementPosition(size_t bytecode_offset, int source_position); 47 void AddStatementPosition(size_t bytecode_offset, int source_position);
28 void AddExpressionPosition(size_t bytecode_offset, int source_position); 48 void AddExpressionPosition(size_t bytecode_offset, int source_position);
29 void RevertPosition(size_t bytecode_offset); 49 Handle<ByteArray> ToSourcePositionTable();
30 Handle<FixedArray> ToFixedArray();
31 50
32 private: 51 private:
33 struct Entry { 52 void AddEntry(const PositionTableEntry& entry);
34 int bytecode_offset;
35 uint32_t source_position_and_type;
36 };
37
38 bool CodeOffsetHasPosition(int bytecode_offset) {
39 // Return whether bytecode offset already has a position assigned.
40 return entries_.size() > 0 &&
41 entries_.back().bytecode_offset == bytecode_offset;
42 }
43 53
44 Isolate* isolate_; 54 Isolate* isolate_;
45 ZoneVector<Entry> entries_; 55 ZoneVector<byte> bytes_;
56 #ifdef ENABLE_SLOW_DCHECKS
57 ZoneVector<PositionTableEntry> raw_entries_;
58 #endif
59 PositionTableEntry previous_;
46 }; 60 };
47 61
48 class SourcePositionTableIterator { 62 class SourcePositionTableIterator {
49 public: 63 public:
50 explicit SourcePositionTableIterator(BytecodeArray* bytecode_array); 64 explicit SourcePositionTableIterator(ByteArray* byte_array);
51 65
52 void Advance(); 66 void Advance();
53 67
54 int bytecode_offset() const { 68 int bytecode_offset() const {
55 DCHECK(!done()); 69 DCHECK(!done());
56 return bytecode_offset_; 70 return current_.bytecode_offset;
57 } 71 }
58 int source_position() const { 72 int source_position() const {
59 DCHECK(!done()); 73 DCHECK(!done());
60 return source_position_; 74 return current_.source_position;
61 } 75 }
62 bool is_statement() const { 76 bool is_statement() const {
63 DCHECK(!done()); 77 DCHECK(!done());
64 return is_statement_; 78 return current_.is_statement;
65 } 79 }
66 bool done() const { return index_ > length_; } 80 bool done() const { return index_ == kDone; }
67 81
68 private: 82 private:
69 FixedArray* table_; 83 static const int kDone = -1;
84
85 ByteArray* table_;
70 int index_; 86 int index_;
71 int length_; 87 PositionTableEntry current_;
72 bool is_statement_;
73 int bytecode_offset_;
74 int source_position_;
75 DisallowHeapAllocation no_gc; 88 DisallowHeapAllocation no_gc;
76 }; 89 };
77 90
78 } // namespace interpreter 91 } // namespace interpreter
79 } // namespace internal 92 } // namespace internal
80 } // namespace v8 93 } // namespace v8
81 94
82 #endif // V8_INTERPRETER_SOURCE_POSITION_TABLE_H_ 95 #endif // V8_INTERPRETER_SOURCE_POSITION_TABLE_H_
OLDNEW
« no previous file with comments | « src/interpreter/bytecode-array-builder.cc ('k') | src/interpreter/source-position-table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698