Added a flag that forces SampleApp to continuously redraw, even in non-animated tests. Helpful when…

Added a flag that forces SampleApp to continuously redraw, even in non-animated tests. Helpful when profiling or debugging.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1731853003

Committed: https://skia.googlesource.com/skia/+/ca34846584f57e0cd39edfc13e9263c29bf0dd03

[Brian Osman, 2016-02-24 19:05:57]

Description was changed from

==========
Added a flag that forces SampleApp to continuously redraw, even in non-animated
tests. Helpful when profiling or debugging.

BUG=skia:
==========

to

==========
Added a flag that forces SampleApp to continuously redraw, even in non-animated
tests. Helpful when profiling or debugging.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[Brian Osman, 2016-02-24 19:09:44]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, ethannicholas@google.com

[ethannicholas, 2016-02-24 19:11:46]

lgtm

Maybe (in a separate change) you could also have it display FPS to stdout when
this option is given? That would be useful.

[f(malita), 2016-02-24 19:15:40]

What's the difference vs. the current 'f' binding (and the related fMeasureFPS
logic)?

[ethannicholas, 2016-02-24 19:17:20]

On 2016/02/24 19:15:40, f(malita) wrote:
> What's the difference vs. the current 'f' binding (and the related fMeasureFPS
> logic)?

The current FPS logic re-renders the scene many times per frame and gives wildly
inaccurate results for GPU mode.

[f(malita), 2016-02-24 19:18:47]

On 2016/02/24 19:17:20, ethannicholas wrote:
> On 2016/02/24 19:15:40, f(malita) wrote:
> > What's the difference vs. the current 'f' binding (and the related
fMeasureFPS
> > logic)?
> 
> The current FPS logic re-renders the scene many times per frame and gives
wildly
> inaccurate results for GPU mode.

I see, thanks.

[Brian Osman, 2016-02-24 19:27:42]

On 2016/02/24 19:18:47, f(malita) wrote:
> On 2016/02/24 19:17:20, ethannicholas wrote:
> > On 2016/02/24 19:15:40, f(malita) wrote:
> > > What's the difference vs. the current 'f' binding (and the related
> fMeasureFPS
> > > logic)?
> > 
> > The current FPS logic re-renders the scene many times per frame and gives
> wildly
> > inaccurate results for GPU mode.
> 
> I see, thanks.

Before Ethan interjected, the answer would have been: "I didn't know about 'f'".
However, his answer is correct - the behavior it introduces isn't ideal for
various GPU profiling and debugging tools. The many different DX and OGL
debugging tools generally have options to trigger a frame capture, and then it
records the full series of commands for the *next* frame. Without this, you
would often have to trigger a capture, then interact with the window in some way
to force a redraw.

Ethan: Yes, I will look at adding a simple FPS counter in this mode, too. ;)

[Brian Osman, 2016-02-24 19:28:01]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-02-24 19:28:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731853003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731853003/1

[commit-bot: I haz the power, 2016-02-24 19:47:49]

Description was changed from

==========
Added a flag that forces SampleApp to continuously redraw, even in non-animated
tests. Helpful when profiling or debugging.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Added a flag that forces SampleApp to continuously redraw, even in non-animated
tests. Helpful when profiling or debugging.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/ca34846584f57e0cd39edfc13e9263c29bf0dd03
==========

[commit-bot: I haz the power, 2016-02-24 19:47:50]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ca34846584f57e0cd39edfc13e9263c29bf0dd03