Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 173183002: Remove oak windows and its flags. (Closed)

Created:
6 years, 10 months ago by oshima
Modified:
6 years, 10 months ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, mazda+watch_chromium.org, kalyank, ben+ash_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : more ui/oak #

Patch Set 3 : remove one more oak.gyp reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -740 lines) Patch
M ash/accelerators/accelerator_controller.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/ash.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M build/all.gyp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -9 lines 0 comments Download
D ui/oak/DEPS View 1 1 chunk +0 lines, -8 lines 0 comments Download
D ui/oak/oak.h View 1 1 chunk +0 lines, -17 lines 0 comments Download
D ui/oak/oak.gyp View 1 1 chunk +0 lines, -49 lines 0 comments Download
D ui/oak/oak_aura_window_display.h View 1 1 chunk +0 lines, -37 lines 0 comments Download
D ui/oak/oak_aura_window_display.cc View 1 1 chunk +0 lines, -162 lines 0 comments Download
D ui/oak/oak_details_model.h View 1 1 chunk +0 lines, -33 lines 0 comments Download
D ui/oak/oak_export.h View 1 1 chunk +0 lines, -32 lines 0 comments Download
D ui/oak/oak_pretty_print.h View 1 1 chunk +0 lines, -31 lines 0 comments Download
D ui/oak/oak_pretty_print.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
D ui/oak/oak_tree_model.h View 1 1 chunk +0 lines, -26 lines 0 comments Download
D ui/oak/oak_tree_model.cc View 1 1 chunk +0 lines, -39 lines 0 comments Download
D ui/oak/oak_window.h View 1 1 chunk +0 lines, -67 lines 0 comments Download
D ui/oak/oak_window.cc View 1 1 chunk +0 lines, -159 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
oshima
6 years, 10 months ago (2014-02-19 23:45:44 UTC) #1
Ben Goodger (Google)
lgtm but can you delete ui/oak also? thanks.
6 years, 10 months ago (2014-02-20 03:06:12 UTC) #2
oshima
oops, done. PTAL.
6 years, 10 months ago (2014-02-20 15:49:11 UTC) #3
Ben Goodger (Google)
lgtm
6 years, 10 months ago (2014-02-20 15:52:59 UTC) #4
oshima
The CQ bit was checked by oshima@chromium.org
6 years, 10 months ago (2014-02-20 16:35:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/173183002/60022
6 years, 10 months ago (2014-02-20 16:37:14 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 19:10:01 UTC) #7
Message was sent while issue was closed. 
Change committed as 252346

Powered by Google App Engine
This is Rietveld 408576698