Service Worker: Add worker client test for Clients.get(id)

Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion: https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-method

Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
Committed: https://crrev.com/21165961cd08e211f8efbe37f937769fb6131f3f
Cr-Commit-Position: refs/heads/master@{#377480}

[jungkees, 2016-02-24 12:56:48]

Description was changed from

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
==========

to

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
==========

[jungkees, 2016-02-24 12:56:48]

jungkee.song@samsung.com changed reviewers:
+ falken@chromium.org, jinho.bang@samsung.com, nhiroki@chromium.org

[jungkees, 2016-02-24 13:00:39]

nhiroki@, I uploaded a snapshot having added a layout test for a worker client.
I did it with a shared worker as the test for matchAll did. PTAL

[nhiroki, 2016-02-24 15:30:43]

lgtm

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html
(right):

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html:30:
return new Promise(function(resolve, reject) {
nit: |reject| can be omitted.

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-get-client-types-shared-worker.js
(right):

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-get-client-types-shared-worker.js:9:
});
nit: Indents look broken.

fetch('clientId')
  .then(function(response) {
      return response.text();
    })
  .then(...)

[jungkees, 2016-02-25 01:06:23]

Thanks for the review. Addressed the comments.

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html
(right):

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/clients-get-client-types.html:30:
return new Promise(function(resolve, reject) {
On 2016/02/24 15:30:43, nhiroki wrote:
> nit: |reject| can be omitted.

Done.

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-get-client-types-shared-worker.js
(right):

https://codereview.chromium.org/1731823003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/clients-get-client-types-shared-worker.js:9:
});
On 2016/02/24 15:30:43, nhiroki wrote:
> nit: Indents look broken.
> 
> fetch('clientId')
>   .then(function(response) {
>       return response.text();
>     })
>   .then(...)

Done.

[jungkees, 2016-02-25 01:07:10]

The CQ bit was checked by jungkee.song@samsung.com

[jungkees, 2016-02-25 01:07:11]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1731823003/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2016-02-25 01:11:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731823003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731823003/20001

[commit-bot: I haz the power, 2016-02-25 02:59:12]

Description was changed from

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
==========

to

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
==========

[commit-bot: I haz the power, 2016-02-25 02:59:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-25 03:00:56]

Description was changed from

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310
==========

to

==========
Service Worker: Add worker client test for Clients.get(id)

As a follow-up of https://codereview.chromium.org/1439333002, this CL adds a
layout test to cover Clients.get(id) for worker clients. Upon verifying the test
result on the chromium waterfall, we plan to make the flag stable.

Spec discussion:
https://github.com/slightlyoff/ServiceWorker/issues/723#issuecomment-151326898
Spec:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#clients-get-...

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/XlBHOIOCjUk

BUG=552310

Committed: https://crrev.com/21165961cd08e211f8efbe37f937769fb6131f3f
Cr-Commit-Position: refs/heads/master@{#377480}
==========

[commit-bot: I haz the power, 2016-02-25 03:00:57]

Patchset 2 (id:??) landed as
https://crrev.com/21165961cd08e211f8efbe37f937769fb6131f3f
Cr-Commit-Position: refs/heads/master@{#377480}