Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1731793008: egl_test.cc: Remove ignored __dllimport

Created:
4 years, 10 months ago by hans
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

egl_test.cc: Remove ignored __dllimport __dllimport doesn't make sense on a typedef. MSVC just ignores it, but Clang ignores and warns, which we treat as an error: ..\..\gpu\command_buffer\tests\egl_test.cc(478,11) : error: 'dllimport' attribute only applies to variables, functions and classes [-Werror,-Wignored-attributes] typedef GL_APICALL void(GL_APIENTRY * glEnableProc)(GLenum); ^ BUG=82385 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel TBR=kkinnunen

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/command_buffer/tests/egl_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731793008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731793008/1
4 years, 10 months ago (2016-02-25 18:33:04 UTC) #5
Kimmo Kinnunen
4 years, 10 months ago (2016-02-26 07:49:47 UTC) #8
Thanks, sorry for the trouble. As you probably noticed, the commit was reverted.
I can incorporate the fix here to the future patch, if it ever gets merged back.

Powered by Google App Engine
This is Rietveld 408576698