Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1731773005: Introduce MicrotasksCompletedCallback. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Introduce MicrotasksCompletedCallback. This calback is run after an attempt to run microtasks. BUG=chromium:585949 LOG=Y Committed: https://crrev.com/66b87c00b8145ba6fbf709504b4571154d103129 Cr-Commit-Position: refs/heads/master@{#34305}

Patch Set 1 #

Total comments: 2

Patch Set 2 : DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -1 line) Patch
M include/v8.h View 2 chunks +21 lines, -1 line 0 comments Download
M src/api.cc View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/isolate.h View 3 chunks +9 lines, -0 lines 0 comments Download
M src/isolate.cc View 2 chunks +31 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 4 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
dgozman
Could you please take a look? Chromium-side patch using this: https://codereview.chromium.org/1733083002/
4 years, 10 months ago (2016-02-25 00:34:30 UTC) #2
jochen (gone - plz use gerrit)
lgtm with comments https://codereview.chromium.org/1731773005/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1731773005/diff/1/src/api.cc#newcode7465 src/api.cc:7465: if (callback == NULL) return; nullptr. ...
4 years, 10 months ago (2016-02-25 12:00:39 UTC) #3
dgozman
https://codereview.chromium.org/1731773005/diff/1/src/api.cc File src/api.cc (right): https://codereview.chromium.org/1731773005/diff/1/src/api.cc#newcode7465 src/api.cc:7465: if (callback == NULL) return; On 2016/02/25 12:00:39, jochen ...
4 years, 10 months ago (2016-02-25 15:26:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731773005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731773005/20001
4 years, 10 months ago (2016-02-25 19:25:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-25 19:48:36 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 19:50:05 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/66b87c00b8145ba6fbf709504b4571154d103129
Cr-Commit-Position: refs/heads/master@{#34305}

Powered by Google App Engine
This is Rietveld 408576698