Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1731773004: Cleanup: Remove buildbot_valgrind.sh, since it is no longer used (Closed)

Created:
4 years, 10 months ago by Mark Seaborn
Modified:
4 years, 10 months ago
Reviewers:
Petr Hosek
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Cleanup: Remove buildbot_valgrind.sh, since it is no longer used buildbot_valgrind.sh is only referenced by trybot entries in buildbot_selector.py, but those trybots aren't in PRESUBMIT.py's default list and they don't work any more. Support for Valgrind hasn't worked since the Linux bots were upgraded to Ubuntu Precise, which was a long time ago. BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=3158 TEST=trybots Committed: https://chromium.googlesource.com/native_client/src/native_client/+/2ca9149a9b43328812333180a54ba5281620cc42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -95 lines) Patch
M buildbot/buildbot_selector.py View 1 chunk +0 lines, -4 lines 0 comments Download
D buildbot/buildbot_valgrind.sh View 1 chunk +0 lines, -91 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Mark Seaborn
4 years, 10 months ago (2016-02-24 22:52:57 UTC) #3
Petr Hosek
lgtm
4 years, 10 months ago (2016-02-24 23:11:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731773004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731773004/1
4 years, 10 months ago (2016-02-24 23:18:08 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 23:19:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/2ca9149a9...

Powered by Google App Engine
This is Rietveld 408576698