Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1731743003: Move precompilation-related flags to flags list. (Closed)

Created:
4 years, 9 months ago by Florian Schneider
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move precompilation-related flags to flags list. They become compile-time constants in the precompiled runtime, and in product mode. In precompiled product mode, the precompiled value has precedence. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/5c9f18c6c87284395564051a052cc4acc9b6f59a Committed: https://github.com/dart-lang/sdk/commit/d8677964a3ca65f8dfc007c29a12767c90139917

Patch Set 1 #

Patch Set 2 : moved FLAG_precompilation #

Patch Set 3 : fix handling of --precompilation flag #

Patch Set 4 : fix product build #

Patch Set 5 : make print_stop_message default false to fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -253 lines) Patch
M runtime/bin/gen_snapshot.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 3 chunks +9 lines, -0 lines 0 comments Download
M runtime/lib/regexp.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/aot_optimizer.cc View 1 2 7 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/block_scheduler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/code_descriptors.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 2 3 3 chunks +1 line, -12 lines 0 comments Download
M runtime/vm/compiler.cc View 1 2 7 chunks +6 lines, -9 lines 0 comments Download
M runtime/vm/compiler_test.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/constant_propagator.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 3 chunks +6 lines, -1 line 0 comments Download
M runtime/vm/debugger.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/flag_list.h View 1 2 3 4 5 chunks +38 lines, -3 lines 0 comments Download
M runtime/vm/flags.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 2 7 chunks +54 lines, -65 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_arm64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/pages.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/pages.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M runtime/vm/precompiler.cc View 1 2 5 chunks +3 lines, -8 lines 0 comments Download
M runtime/vm/profiler_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/redundancy_elimination.cc View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/snapshot.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 5 chunks +5 lines, -4 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/weak_code.cc View 1 2 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Florian Schneider
Most files only have flag declarations removed, so the CL looks much bigger than it ...
4 years, 9 months ago (2016-02-24 20:50:52 UTC) #3
rmacnak
lgtm
4 years, 9 months ago (2016-02-25 00:13:36 UTC) #4
Florian Schneider
Committed patchset #4 (id:60001) manually as 5c9f18c6c87284395564051a052cc4acc9b6f59a (presubmit successful).
4 years, 9 months ago (2016-02-25 01:31:21 UTC) #6
Florian Schneider
TBR Made print_stop_message default false to fix build (arm64)
4 years, 9 months ago (2016-02-25 15:17:45 UTC) #7
Florian Schneider
4 years, 9 months ago (2016-02-25 15:53:45 UTC) #9
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
d8677964a3ca65f8dfc007c29a12767c90139917 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698