Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 1731733003: [Externs] Support binary/ArrayBuffer type (Closed)

Created:
4 years, 10 months ago by Devlin
Modified:
4 years, 10 months ago
CC:
chromium-reviews, Dan Beam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Externs] Support binary/ArrayBuffer type The binary/ArrayBuffer type corresponds to the js ArrayBuffer type (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer) Add support for this in the auto-generated externs and add tests for same. BUG=588993 Committed: https://crrev.com/3291fa8bb69740fc7ecb496394d53fde2daeafae Cr-Commit-Position: refs/heads/master@{#377439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/json_schema_compiler/js_externs_generator_test.py View 4 chunks +9 lines, -2 lines 0 comments Download
M tools/json_schema_compiler/js_util.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Devlin
Tyler, mind taking a look? Dan, just FYI.
4 years, 10 months ago (2016-02-24 06:07:43 UTC) #3
Tyler Breisacher (Chromium)
cool, lgtm. Are there any existing externs files that need to be regenerated now, or ...
4 years, 10 months ago (2016-02-24 17:51:06 UTC) #4
Devlin
On 2016/02/24 17:51:06, Tyler Breisacher (Chromium) wrote: > cool, lgtm. Are there any existing externs ...
4 years, 10 months ago (2016-02-24 23:49:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1731733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1731733003/1
4 years, 10 months ago (2016-02-24 23:54:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-25 00:40:31 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-25 00:41:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3291fa8bb69740fc7ecb496394d53fde2daeafae
Cr-Commit-Position: refs/heads/master@{#377439}

Powered by Google App Engine
This is Rietveld 408576698