chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java - Issue 1731673002: Add tab reparenting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Dan's final nits Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModel.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/ActivityDelegate.java » ('j') | content/browser/android/content_view_core_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

index c2c55e060cc1e038b69fc615af62bef31ccb4989..5c6c7a729b5ae2bf22a0d39defbe1435d0e60000 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelImpl.java

@@ -84,6 +84,11 @@ public class TabModelImpl extends TabModelJniBridge {

}

@Override

+ public void removeTab(Tab tab) {

+ mTabs.remove(tab);

+ }

+ @Override

public void destroy() {

for (Tab tab : mTabs) {

if (tab.isInitialized()) tab.destroy();