Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4256)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove test Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java
index e5f91d690bf390801b4228411fd356ab1590078e..b7ba9ec072b308f5c0ad668998a603209fb8c322 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java
@@ -24,13 +24,26 @@ public class AsyncTabParamsManager {
}
/**
- * @return Whether there are any saved {@link AsyncTabParams} with the given tab id.
+ * @return Whether there is already an {@link AsyncTabParams} added for the given ID.
*/
public static boolean hasParamsForTabId(int tabId) {
return sAsyncTabParams.get(tabId) != null;
}
/**
+ * @return Whether there are any saved {@link AsyncTabParams} with a tab to reparent. All
+ * implementations of this are keyed off of a user gesture so the likelihood of having
+ * more than one is zero.
+ */
+ public static boolean hasParamsWithTabToReparent() {
+ for (int i = 0; i < sAsyncTabParams.size(); i++) {
+ if (sAsyncTabParams.get(sAsyncTabParams.keyAt(i)).getTabToReparent() == null) continue;
+ return true;
+ }
+ return false;
+ }
+
+ /**
* @return Retrieves and removes AsyncTabCreationParams for a particular tab id.
*/
public static AsyncTabParams remove(int tabId) {

Powered by Google App Engine
This is Rietveld 408576698