chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java - Issue 1731673002: Add tab reparenting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java

Issue 1731673002: Add tab reparenting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added visible for testing to externalPrerenderHandler method Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParamsManager.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java

index a7d18034eba5889111948a46b563a3f94765d1e2..596df2c9065b0da1a53d56a065b7fc8b1795a649 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/AsyncTabParams.java

@@ -39,4 +39,9 @@ public interface AsyncTabParams {

* @return The tab that would be reparenting through this {@link AsyncTabParams}. Can be null.

Tab getTabToReparent();

+ /**

+ * Destroy any internal fields if it is necessary.

+ */

+ void destroy();

}