Add tab reparenting

chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.banners;
 
 import android.content.Context;
 import android.text.TextUtils;
 
 import org.chromium.base.ApplicationStatus;
@@ skipping 22 matching lines @@
 
     /** Retrieves information about a given package. */
     private static AppDetailsDelegate sAppDetailsDelegate;
 
     /** Whether the banners are enabled. */
     private static Boolean sIsEnabled;
 
     /** Pointer to the native side AppBannerManager. */
     private long mNativePointer;
 
-    /** Tab that the AppBannerView/AppBannerManager is owned by. */
-    private final Tab mTab;
-
     /**
      * Checks if app banners are enabled.
      * @return True if banners are enabled, false otherwise.
      */
     public static boolean isEnabled() {
         if (sIsEnabled == null) {
             Context context = ApplicationStatus.getApplicationContext();
             sIsEnabled = ShortcutHelper.isAddToHomeIntentSupported(context);
         }
         return sIsEnabled;
     }
 
     /**
      * Sets the delegate that provides information about a given package.
      * @param delegate Delegate to use.  Previously set ones are destroyed.
      */
     public static void setAppDetailsDelegate(AppDetailsDelegate delegate) {
         if (sAppDetailsDelegate != null) sAppDetailsDelegate.destroy();
         sAppDetailsDelegate = delegate;
     }
 
     /**
      * Constructs an AppBannerManager for the given tab.
      * @param tab Tab that the AppBannerManager will be attached to.
      */
     public AppBannerManager(Tab tab, Context context) {
         mNativePointer = nativeInit();
-        mTab = tab;
-        updatePointers();
+        updatePointers(tab);
     }
 
     @Override
     public void onWebContentsSwapped(Tab tab, boolean didStartLoad,
             boolean didFinishLoad) {
-        updatePointers();
+        updatePointers(tab);
     }
 
     @Override
     public void onContentChanged(Tab tab) {
-        updatePointers();
+        updatePointers(tab);
     }
 
     /**
      * Destroys the native AppBannerManager.
      */
     public void destroy() {
         nativeDestroy(mNativePointer);
         mNativePointer = 0;
     }
 
     /**
      * Updates which WebContents the native AppBannerManager is monitoring.
      */
-    private void updatePointers() {
-        nativeReplaceWebContents(mNativePointer, mTab.getWebContents());
+    private void updatePointers(Tab tab) {
+        nativeReplaceWebContents(mNativePointer, tab.getWebContents());
     }
 
     /**
      * Grabs package information for the banner asynchronously.
      * @param url         URL for the page that is triggering the banner.
      * @param packageName Name of the package that is being advertised.
      */
     @CalledByNative
     private void fetchAppDetails(
             String url, String packageName, String referrer, int iconSizeInDp) {
@@ skipping 69 matching lines @@
             AppData data, String title, String packageName, String imageUrl);
     private native void nativeRequestAppBanner(long nativeAppBannerManagerAndroid);
 
     // Testing methods.
     private static native void nativeSetTimeDeltaForTesting(int days);
     private static native void nativeDisableSecureSchemeCheckForTesting();
     private static native void nativeSetEngagementWeights(double directEngagement,
             double indirectEngagement);
     private native boolean nativeIsFetcherActive(long nativeAppBannerManagerAndroid);
 }