Allow bitwise operators to convert from intish to int in heap ops.

Allow bitwise operators to convert from intish to int in heap ops.

We previously supported use of bitwise operations to convert
from intish to int, but use of kAsmInt in some places and kAsmIntQ
in others prevents this from working with heap accesses.
Switch to use kAsmIntQ where appropriate (even though intish_ != 0
in principle captures the superset of these cases),
as it's more conservative (and uses types.h better).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/a52967680edeacb45a97b5c0615eeb346c54a355
Cr-Commit-Position: refs/heads/master@{#34233}

[aseemgarg, 2016-02-24 02:16:21]

lgtm

https://codereview.chromium.org/1731603002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1731603002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1528: (function TestAndIntishAndFromHeap() {
Better name? TestAndIntAndHeapValue?

[bradn, 2016-02-24 07:15:19]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2016-02-24 07:15:20]

https://codereview.chromium.org/1731603002/diff/1/test/mjsunit/wasm/asm-wasm.js
File test/mjsunit/wasm/asm-wasm.js (right):

https://codereview.chromium.org/1731603002/diff/1/test/mjsunit/wasm/asm-wasm....
test/mjsunit/wasm/asm-wasm.js:1528: (function TestAndIntishAndFromHeap() {
On 2016/02/24 02:16:21, aseemgarg wrote:
> Better name? TestAndIntAndHeapValue?

Done.

[bradn, 2016-02-24 07:15:24]

The CQ bit was checked by bradnelson@google.com

[bradn, 2016-02-24 07:15:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
aseemgarg@chromium.org
Link to the patchset: https://codereview.chromium.org/1731603002/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2016-02-24 07:15:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1731603002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1731603002/20001

[commit-bot: I haz the power, 2016-02-24 07:35:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 07:36:45]

Description was changed from

==========
Allow bitwise operators to convert from intish to int in heap ops.

We previously supported use of bitwise operations to convert
from intish to int, but use of kAsmInt in some places and kAsmIntQ
in others prevents this from working with heap accesses.
Switch to use kAsmIntQ where appropriate (even though intish_ != 0
in principle captures the superset of these cases),
as it's more conservative (and uses types.h better).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N
==========

to

==========
Allow bitwise operators to convert from intish to int in heap ops.

We previously supported use of bitwise operations to convert
from intish to int, but use of kAsmInt in some places and kAsmIntQ
in others prevents this from working with heap accesses.
Switch to use kAsmIntQ where appropriate (even though intish_ != 0
in principle captures the superset of these cases),
as it's more conservative (and uses types.h better).

BUG= https://code.google.com/p/v8/issues/detail?id=4203
TEST=mjsunit/asm-wasm
R=aseemgarg@chromium.org,titzer@chromium.org
LOG=N

Committed: https://crrev.com/a52967680edeacb45a97b5c0615eeb346c54a355
Cr-Commit-Position: refs/heads/master@{#34233}
==========

[commit-bot: I haz the power, 2016-02-24 07:36:46]

Patchset 2 (id:??) landed as
https://crrev.com/a52967680edeacb45a97b5c0615eeb346c54a355
Cr-Commit-Position: refs/heads/master@{#34233}